[stable-2.5] Migrate from MySQLdb to PyMySQL (#40123) #45982
Conversation
* Migrate from MySQLdb to PyMySQL * Deduplicate driver loading and failure message * Explain requirements * Apply requirements docs change to proxysql too * Add changelog. (cherry picked from commit d34cf93) Co-authored-by: Daniel Speichert <DSpeichert@users.noreply.github.com>
ansibot
added
affects_2.5
s-hertel
removed
the
needs_triage
|
(EDIT NM, after discussing with the other RMs and looking at the code, I see you're not "migrating" but adding a new option). This doesn't seem like a great candidate for a backport, since it will break every user of this module until they swap their deps. We try really hard not to make breaking changes like that in service releases unless it's something very drastic like a REST API that's been completely shut down, where the module will be totally non-functional going forward without a change like this... I don't think this falls into that category, so I'm going to close the backport PR. |
|
@nitzmahone It'll try pymysql first, then fall back to the old driver: https://github.com/ansible/ansible/pull/45982/files#diff-574ce10847bde8823e28af27d7cc3839 |
|
Right, but the test deps always install the new driver, so after this change, nothing will test the old code path.. Right? |
|
Looks like RHEL still runs with the old dep, so I'm 👍 to go ahead and take this for 2.5.10. |
(cherry picked from commit d34cf93)
Co-authored-by: Daniel Speichert DSpeichert@users.noreply.github.com
SUMMARY
Fixes #29887
ISSUE TYPE
COMPONENT NAME
mysql_db
ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION
Backport of #40123