Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOTMETA: Move rabbitmq modules to own directory #46064

Merged
merged 2 commits into from Oct 30, 2018

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Sep 24, 2018

SUMMARY

This makes it possible to automatically include $team_rabbitmq for new modules.

This PR also includes:

  • Fixes to author fields
  • Fixes to copyright statements
  • Fixes to short_description
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

BOTMETA.yml

ANSIBLE VERSION

v2.8

@dagwieers dagwieers force-pushed the rabbitmq-move branch 2 times, most recently from 227bb0a to 898abae Compare September 24, 2018 12:05
@ansibot

This comment has been minimized.

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 24, 2018
@dagwieers
Copy link
Contributor Author

bot_skip

@dagwieers dagwieers removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. labels Sep 24, 2018
@jctanner
Copy link
Contributor

Does chrishoffman want to be notified now? I don't understand why we would take out the ingore field for his username.

@dagwieers
Copy link
Contributor Author

dagwieers commented Sep 24, 2018

@jctanner It was the wrong Github handle (choffman vs chrishoffman), beats me how this could end up there. Typo ?

https://github.com/ansible/ansible/pull/46064/files#diff-7920eca0d9e6bb899a9ef1ab76165190R23

And I assume the other user complained he was notified about stuff, so we ignored that handle.

@pilou-
Copy link
Contributor

pilou- commented Sep 24, 2018

This makes it possible to automatically include $team_rabbitmq for new modules.

Could not $modules/messaging/rabbitmq_: $team_rabbitmq be used instead ?

The downside of creating modules/messaging/rabbitmq/ is that the only namespace maintainers of messaging/rabbitmq are the rabbitmq module authors. But there are only rabbitmq modules below messaging, then that's not a problem :)

@dagwieers
Copy link
Contributor Author

@pilou- That would work as well, but I don't see why you wouldn't do the right thing anyway.

@pilou-
Copy link
Contributor

pilou- commented Sep 24, 2018

Maybe notion of namespace maintainers should be redefined. Should not all the messaging maintainers be namespace maintainers of rabbitmq modules ? I mean: we want more maintainers not less.

@dagwieers
Copy link
Contributor Author

@pilou- Please continue that discussion in another issue or PR. (Hint: look at $team_network for an existing situation)

@pilou-
Copy link
Contributor

pilou- commented Sep 25, 2018

Please continue that discussion in another issue or PR. (Hint: look at $team_network for an existing situation)

I don't understand

@dagwieers
Copy link
Contributor Author

@pilou- Your discussion has nothing to do with this PR. You are talking about "messaging maintainers", but there are no "messaging maintainers" (only $team_rabbitmq), so this is a hypothetical discussion. I am not looking for hypothetical discussions, so whatever case you want to make, please look for another forum to do this.

@pilou-
Copy link
Contributor

pilou- commented Sep 25, 2018

Did you miss the part where I wrote that I did not disagree with theses changes ?

But there are only rabbitmq modules below messaging, then that's not a problem :)

@dagwieers
Copy link
Contributor Author

@pilou- My response was to:

Maybe notion of namespace maintainers should be redefined. Should not all the messaging maintainers be namespace maintainers of rabbitmq modules ? I mean: we want more maintainers not less.

There are no "messaging maintainers" so I don't see your point and it seems you are having a parallel discussion in this PR. If you don't agree, that's fine. No clue what the above is about though.

@acozine
Copy link
Contributor

acozine commented Oct 2, 2018

@pilou- right now the rabbitmq is the only messaging utility with ansible modules, but that situation probably won't last forever; this change gets us ready for the future, and allows the rabbitmq maintainers to decide if they want to maintain other messaging modules, or only rabbitmq ones

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Rebase then merge

This makes it possible to automatically include $team_rabbitmq for new modules.
@acozine acozine merged commit b7e77c4 into ansible:devel Oct 30, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
Moving rabbitmq modules to own directory makes it possible to automatically include $team_rabbitmq for new modules.
@dagwieers dagwieers added the rabbitmq RabbitMQ community label Jan 28, 2019
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. rabbitmq RabbitMQ community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants