New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOTMETA: Move rabbitmq modules to own directory #46064
Conversation
227bb0a
to
898abae
Compare
This comment has been minimized.
This comment has been minimized.
898abae
to
8434d95
Compare
bot_skip |
Does chrishoffman want to be notified now? I don't understand why we would take out the ingore field for his username. |
@jctanner It was the wrong Github handle (choffman vs chrishoffman), beats me how this could end up there. Typo ? https://github.com/ansible/ansible/pull/46064/files#diff-7920eca0d9e6bb899a9ef1ab76165190R23 And I assume the other user complained he was notified about stuff, so we ignored that handle. |
Could not The downside of creating |
@pilou- That would work as well, but I don't see why you wouldn't do the right thing anyway. |
Maybe notion of |
@pilou- Please continue that discussion in another issue or PR. (Hint: look at $team_network for an existing situation) |
I don't understand |
@pilou- Your discussion has nothing to do with this PR. You are talking about "messaging maintainers", but there are no "messaging maintainers" (only $team_rabbitmq), so this is a hypothetical discussion. I am not looking for hypothetical discussions, so whatever case you want to make, please look for another forum to do this. |
8434d95
to
4a410ee
Compare
Did you miss the part where I wrote that I did not disagree with theses changes ?
|
@pilou- My response was to:
There are no "messaging maintainers" so I don't see your point and it seems you are having a parallel discussion in this PR. If you don't agree, that's fine. No clue what the above is about though. |
4a410ee
to
8eab10b
Compare
@pilou- right now the rabbitmq is the only messaging utility with ansible modules, but that situation probably won't last forever; this change gets us ready for the future, and allows the rabbitmq maintainers to decide if they want to maintain other messaging modules, or only rabbitmq ones |
8eab10b
to
62101fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Rebase then merge
This makes it possible to automatically include $team_rabbitmq for new modules.
62101fb
to
bf423b5
Compare
Moving rabbitmq modules to own directory makes it possible to automatically include $team_rabbitmq for new modules.
SUMMARY
This makes it possible to automatically include $team_rabbitmq for new modules.
This PR also includes:
ISSUE TYPE
COMPONENT NAME
BOTMETA.yml
ANSIBLE VERSION
v2.8