Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 collections compatibility fixes. #46557

Merged
merged 1 commit into from Oct 8, 2018
Merged

Python 3.8 collections compatibility fixes. #46557

merged 1 commit into from Oct 8, 2018

Conversation

mattclay
Copy link
Member

@mattclay mattclay commented Oct 5, 2018

SUMMARY

Python 3.8 collections compatibility fixes.

Includes a new pylint blacklist plugin to prevent regressions.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

various

ANSIBLE VERSION
ansible 2.8.0.dev0 (collections-compat 20d915e97f) last updated 2018/10/05 14:37:00 (GMT -700)
  config file = None
  configured module search path = [u'/Users/mclay/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/mclay/code/mattclay/ansible/lib/ansible
  executable location = /Users/mclay/code/mattclay/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 22 2018, 11:39:16) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Oct 5, 2018

Thanks @mattclay! This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Oct 5, 2018
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Oct 5, 2018
@mattclay
Python 3.8 collections compatibility fixes.
bf81fdb 
Includes a new pylint blacklist plugin to prevent regressions.
@mattclay mattclay removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 6, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Oct 6, 2018
webknjaz
webknjaz approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abadger
Copy link
Contributor

abadger commented Oct 6, 2018

+1

@mattclay mattclay merged commit a11f631 into ansible:devel Oct 8, 2018
@mattclay mattclay deleted the collections-compat branch October 8, 2018 18:26
@mattclay mattclay mentioned this pull request Mar 12, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@sivel sivel Awaiting requested review from sivel

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattclay @ansibot @abadger @webknjaz