Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic security group #46571

Merged
merged 1 commit into from Oct 21, 2018
Merged

feat: dynamic security group #46571

merged 1 commit into from Oct 21, 2018

Conversation

abarbare
Copy link
Contributor

@abarbare abarbare commented Oct 6, 2018

SUMMARY

Create security group instead of using environment variable for scaleway security group rule legacy test module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

scaleway_security_group_rule

ANSIBLE VERSION
ansible 2.8.0.dev0 (fix-user-data 686ea77667) last updated 2018/10/06 12:08:53 (GMT +200)
  config file = /Users/abarbare/.ansible.cfg
  configured module search path = [u'/Users/abarbare/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/abarbare/Documents/ansible/lib/ansible
  executable location = /Users/abarbare/Documents/ansible/bin/ansible
  python version = 2.7.15 (default, Jul 23 2018, 21:27:06) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Oct 6, 2018

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 6, 2018
@ryansb ryansb removed needs_triage Needs a first human triage before being processed. labels Oct 9, 2018
@abarbare
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Oct 10, 2018

Components

test/legacy/roles/scaleway_security_group_rule/tasks/main.yml
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 14, 2018
@abarbare
Copy link
Contributor Author

abarbare commented Oct 20, 2018

Rebased to last devel

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 20, 2018
@gundalow gundalow merged commit 6d6245d into ansible:devel Oct 21, 2018
@gundalow
Copy link
Contributor

Merged into devel

@gundalow
Copy link
Contributor

If you need a backport into stable-2.7, please raise a PR by following https://docs.ansible.com/ansible/latest/community/development_process.html#backport-pull-request-process

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants