Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some cliconf plugins #47141

Merged
merged 3 commits into from
Oct 18, 2018
Merged

Update some cliconf plugins #47141

merged 3 commits into from
Oct 18, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Oct 16, 2018 •
edited

SUMMARY

Exposes network_cli functionality to more platform cliconf plugins.

Query: Most of these options pass straight through to network_cli. Would a **kwargs for those options be acceptable, in order to reduce work on cliconf plugins?

Fixes #47143

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cliconf/aireos
cliconf/edgeos
many more

ANSIBLE VERSION
2.8

@mfisher30 mfisher30 mentioned this pull request Oct 16, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @Qalthos, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Oct 17, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Oct 17, 2018
ganeshrn
ganeshrn reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc we discussed using kwargs and opted to not use it in favor of well-defined API signature.
I think it is safe add this change for all the remaining community platforms that has cliconf plugins

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

cc @LindsayHill @bigmstone @heuels @paulquack @rdvencioneck @samerd
click here for bot help

@LindsayHill
Copy link
Contributor

Looks like nos.py needs the same change?

@Qalthos
Copy link
Contributor Author

Qalthos commented Oct 18, 2018

@LindsayHill good catch, added

@ansibot ansibot added the community_review In order to be merged, this PR must follow the community review workflow. label Oct 18, 2018
@LindsayHill
Copy link
Contributor

@Qalthos thanks for adding that - saved me doing it. The NOS modules are pretty new, and I want them to stay in line with the Ansible Network Team-developed modules as much as possible

@Qalthos Qalthos merged commit 7844a40 into ansible:devel Oct 18, 2018
@Qalthos Qalthos deleted the cliconf-tweaks branch October 18, 2018 19:26
Qalthos added a commit to Qalthos/ansible that referenced this pull request Oct 18, 2018
@Qalthos
[2.7] Update some cliconf plugins (ansible#47141)
793dd34 
* Add `check_all` to many community cliconf plugins
(cherry picked from commit 7844a40)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
abadger pushed a commit that referenced this pull request Oct 22, 2018
@Qalthos @abadger
[2.7] Update some cliconf plugins (#47141) (#47310)
7d936c1 
* [2.7] Update some cliconf plugins (#47141)

* Add `check_all` to many community cliconf plugins
(cherry picked from commit 7844a40)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* Add changelog entry
@mfisher30
Copy link

Just curious, does anyone happen to know what version of Ansible this will be included with? A patch release for 2.7 (2.7.1, 2.7.2, etc..) or 2.8?

@LindsayHill
Copy link
Contributor

LindsayHill commented Nov 2, 2018 •
edited

@mfisher30 follow the PR referenced above
#47130

See
#47310 (comment)

Merged for the 2.7.1 release

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@Qalthos @Tomorrow9
Update some cliconf plugins (ansible#47141)
b0c26f8 
* Add `check_all` to many community cliconf plugins
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn left review comments

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@privateip privateip Awaiting requested review from privateip

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
5 participants
@Qalthos @ansibot @LindsayHill @mfisher30 @ganeshrn