Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters to os_router and os_subnet Fixes #37921 #47220

Merged
merged 1 commit into from Nov 24, 2018
Merged

Add filters to os_router and os_subnet Fixes #37921 #47220

merged 1 commit into from Nov 24, 2018

Conversation

racciari
Copy link
Contributor

SUMMARY

Adding project filter to get_subnet and get_network functions when specified to be consistent when running or_router and os_subnet modules.

Fixes #37921

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_router
os_subnet

ANSIBLE VERSION
$ ansible --version
ansible 2.7.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/racciari/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/racciari/ansible-latest/lib/python2.7/site-packages/ansible
  executable location = /home/racciari/ansible-latest/bin/ansible
  python version = 2.7.5 (default, Jul 13 2018, 13:06:57) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

Hi @racciari, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 17, 2018

cc @dagnello @emonty @juliakreger @mnaser @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Oct 17, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Oct 17, 2018

Build succeeded (third-party-check pipeline).

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Oct 18, 2018
@mnaser
Copy link
Contributor

mnaser commented Oct 20, 2018

shipit

@ansibot
Copy link
Contributor

ansibot commented Oct 28, 2018

cc @cloudnull @evrardjp @odyssey4me
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 28, 2018
@racciari
Copy link
Contributor Author

racciari commented Nov 6, 2018

Hey there, is there anyone to review it ?

@gundalow
Copy link
Contributor

@dagnello @emonty @juliakreger @mnaser @omgjlk @rcarrillocruz @Shrews @Thingee looks like a straight forward patch, could you review please?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 23, 2018
evrardjp
evrardjp approved these changes Nov 24, 2018
View reviewed changes
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evrardjp
Copy link
Contributor

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Nov 24, 2018
@ansibot ansibot merged commit 4b1b0bc into ansible:devel Nov 24, 2018
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@racciari @mjmayer
Add filters to os_router and os_subnet Fixes ansible#37921 (ansible#4…
017a946 
…7220)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evrardjp evrardjp evrardjp approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple matches found even when using project parameter on openstack modules
6 participants
@racciari @ansibot @mnaser @gundalow @evrardjp @jborean93