ovirt_vm: Check next_run configuration update if exist #47280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the update check method so it now check also the next_run configuration of the virtual machine if it exists. So if previously the VM was updated with new parameters, and then reset back, the module didn't set the parameters to be set back in next_run. This PR fixes it so the next run configuration is set back with proper parameters. Signed-off-by: Ondra Machacek <omachace@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894 Signed-off-by: Ondra Machacek <omachace@redhat.com>
machacekondra
force-pushed
the
ovirt_vm_add_next_run_check
branch
from
66d546a
to
ef3ea6c
Compare
|
Hi @machacekondra, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
|
shipit |
ansibot
added
automerge
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
This PR fixes the update check method so it now check also the next_run configuration of the virtual machine if it exists. So if previously the VM was updated with new parameters, and then reset back, the module didn't set the parameters to be set back in next_run. This PR fixes it so the next run configuration is set back with proper parameters. Signed-off-by: Ondra Machacek <omachace@redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894 Signed-off-by: Ondra Machacek <omachace@redhat.com>
dagwieers
added
ovirt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the update check method so it now check also the next_run
configuration of the virtual machine if it exists.
So if previously the VM was updated with new parameters, and then reset
back, the module didn't set the parameters to be set back in next_run.
This PR fixes it so the next run configuration is set back with proper
parameters.
Signed-off-by: Ondra Machacek omachace@redhat.com
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894
ISSUE TYPE
COMPONENT NAME
ovirt_vm
ANSIBLE VERSION
ADDITIONAL INFORMATION