Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_host_pm: Bug fixes for power management #47659

Merged
merged 1 commit into from
Oct 26, 2018
Merged

ovirt_host_pm: Bug fixes for power management #47659

merged 1 commit into from
Oct 26, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

ovirt_host_pm: Fix to powermanagement module

This PR is fixing following issues:

 1) Don't try to check password.
 2) Check options.
 3) Order wasn't adding at the end, as doc says.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_host_pm

ANSIBLE VERSION
2.7.1
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

Hi @machacekondra, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 26, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 26, 2018
@machacekondra
ovirt_host_pm: Fix to powermanagement module
50d2012 
This PR is fixing following issues:

 1) Don't try to check password.
 2) Check options.
 3) Order wasn't adding at the end, as doc says.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 26, 2018
mwperina
mwperina approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 26, 2018
@ansibot ansibot merged commit ec441cd into ansible:devel Oct 26, 2018
machacekondra added a commit to machacekondra/ansible that referenced this pull request Oct 26, 2018
@machacekondra
ovirt_host_pm: Fix to powermanagement module (ansible#47659)
2de87aa 
This PR is fixing following issues:

 1) Don't try to check password.
 2) Check options.
 3) Order wasn't adding at the end, as doc says.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
@machacekondra machacekondra mentioned this pull request Oct 26, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 31, 2018
@machacekondra @abadger
ovirt_host_pm: Fix to powermanagement module (#47659)
6cf1814 
This PR is fixing following issues:

 1) Don't try to check password.
 2) Check options.
 3) Order wasn't adding at the end, as doc says.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@machacekondra @Tomorrow9
ovirt_host_pm: Fix to powermanagement module (ansible#47659)
2c427f6 
This PR is fixing following issues:

 1) Don't try to check password.
 2) Check options.
 3) Order wasn't adding at the end, as doc says.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machacekondra @ansibot @mwperina @dagwieers @mkrizek