fix curses.setupterm() error in pause module #47851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run playbook in celery task, curses.setupterm() will be failed
```
File "<frozen importlib._bootstrap>", line 675, in _load
File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
File "/Users/guang/.virtualenvs/ansible/lib/python3.6/site-packages/ansible/plugins/action/pause.py", line 45, in <module>
curses.setupterm()
TypeError: argument must be an int, or have a fileno() method.
```
|
Hi @ibuler, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
jborean93
removed
the
needs_triage
gundalow
reviewed
Nov 5, 2018
| @@ -44,7 +44,7 @@ | |||
| try: | |||
| curses.setupterm() | |||
| HAS_CURSES = True | |||
| except curses.error: | |||
| except (curses.error, TypeError): | |||
There was a problem hiding this comment.
I think that is right but it could just as easily be except Exception:
(reason being that any failure there would mean that we don't have a working curses and need to resort to the fallback code)
There was a problem hiding this comment.
Just wondering why once was picked other the other
There was a problem hiding this comment.
in general we try to narrow down exceptions to avoid 'capture globbing' errors
bcoca
changed the title
samdoran
approved these changes
Nov 8, 2018
ansibot
added
the
stale_ci
ansibot
added
needs_revision
|
@ibuler Could you please add a |
ansibot
added
the
stale_ci
ansibot
removed
small_patch
stale_ci
ansibot
added
support:community
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Jun 29, 2020
* [Bugfix] curses.setupterm() error
When run playbook in celery task, curses.setupterm() will be failed
```
File "<frozen importlib._bootstrap>", line 675, in _load
File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
File "/Users/guang/.virtualenvs/ansible/lib/python3.6/site-packages/ansible/plugins/action/pause.py", line 45, in <module>
curses.setupterm()
TypeError: argument must be an int, or have a fileno() method.
```
* Add changelog
Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit c3fc2d2)
Co-authored-by: 老广 <ibuler@qq.com>
nitzmahone
pushed a commit
that referenced
this pull request
Jul 17, 2020
* [Bugfix] curses.setupterm() error
When run playbook in celery task, curses.setupterm() will be failed
```
File "<frozen importlib._bootstrap>", line 675, in _load
File "<frozen importlib._bootstrap>", line 655, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed
File "/Users/guang/.virtualenvs/ansible/lib/python3.6/site-packages/ansible/plugins/action/pause.py", line 45, in <module>
curses.setupterm()
TypeError: argument must be an int, or have a fileno() method.
```
* Add changelog
Co-authored-by: Sam Doran <sdoran@redhat.com>
(cherry picked from commit c3fc2d2)
Co-authored-by: 老广 <ibuler@qq.com>
Co-authored-by: 老广 <ibuler@qq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When run playbook in celery task, curses.setupterm() will be failed, In celery worker may be no sys.stdin fileno, so catch this error
ISSUE TYPE
COMPONENT NAME
plugins/pause
ANSIBLE VERSION
ADDITIONAL INFORMATION