Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a more in depth doc on cacheable option #47878

Merged
merged 3 commits into from Nov 7, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Oct 31, 2018

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

set_fact

ANSIBLE VERSION
2.4+

@bcoca bcoca changed the title a more indepth doc on cacheable option a more in depth doc on cacheable option Oct 31, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 31, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 31, 2018
@@ -35,8 +35,9 @@
required: true
cacheable:
description:
- This boolean indicates if the facts set will also be added to the
fact cache, if fact caching is enabled.
- This boolean converts the variable into and actual 'fact' which will also be added to the fact cache, if fact caching is enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/and/an/

- This boolean indicates if the facts set will also be added to the
fact cache, if fact caching is enabled.
- This boolean converts the variable into and actual 'fact' which will also be added to the fact cache, if fact caching is enabled.
- Normally this module creates 'host level variables' and has much higher precedence, this option changes the nature and precedence
Copy link
Contributor

@jborean93 jborean93 Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to state what that precedence is in terms of the ones at https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable (maybe just a link).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, that list already states 'set_fact' vs 'host fact' are 7 steps away

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, should have actually gone to that link and read it properly

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 1, 2018
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 1, 2018
@ansible ansible deleted a comment from ansibot Nov 6, 2018
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. small_patch labels Nov 6, 2018
@bcoca bcoca merged commit 4961f00 into ansible:devel Nov 7, 2018
@bcoca bcoca deleted the update_set_fact_docs branch November 7, 2018 16:06
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
* a more indepth doc on cacheable option
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
* a more indepth doc on cacheable option
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants