docs - adapted abadger's changelog announcement email into dev process #48172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Miller <admiller@redhat.com>
|
Hi @maxamillion, thank you for submitting this pull-request! |
ansibot
added
affects_2.8
gundalow
reviewed
Nov 6, 2018
| Changelogs | ||
| ---------- | ||
|
|
||
| Please add a changelog fragment with any PR that is |
There was a problem hiding this comment.
Bullet points for needs/does not need list could make this more readable
acozine
suggested changes
Nov 6, 2018
There was a problem hiding this comment.
Nice addition. As we discussed on IRC, this PR should also deduplicate material here vs. material on https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#changelogs, and link between them.
gundalow
removed
the
needs_triage
jamescassell
approved these changes
Nov 6, 2018
ansibot
added
needs_revision
Signed-off-by: Adam Miller <admiller@redhat.com>
ansibot
added
needs_ci
Signed-off-by: Adam Miller <admiller@redhat.com>
willthames
suggested changes
Nov 7, 2018
jamescassell
approved these changes
Nov 10, 2018
|
Big "Thank You!" to @acozine for picking this up and running with it while I was on PTO. Does this need anything else or is it good to merge? |
|
I think it's ready to go, especially since @gundalow is going to be making additional changes to this page and this section. I think the changes in this PR set the ground-work for the next round of changes. |
gundalow
approved these changes
Nov 13, 2018
|
@maxamillion Thank you for doing this, it's a big help |
mjmayer
pushed a commit
to mjmayer/ansible
that referenced
this pull request
Nov 30, 2018
ansible#48172) * docs - adapted abadger's changelog announcement email into dev process Signed-off-by: Adam Miller <admiller@redhat.com> * migrate changelog docs to one place, add ref to old location Signed-off-by: Adam Miller <admiller@redhat.com> * add changes based on feedback Signed-off-by: Adam Miller <admiller@redhat.com> * Refines changelog docs, minor re-org of page * moves links and anchors for new content * Further reorg of page * fixes header per jamescassell
Tomorrow9
pushed a commit
to Tomorrow9/ansible
that referenced
this pull request
Dec 4, 2018
ansible#48172) * docs - adapted abadger's changelog announcement email into dev process Signed-off-by: Adam Miller <admiller@redhat.com> * migrate changelog docs to one place, add ref to old location Signed-off-by: Adam Miller <admiller@redhat.com> * add changes based on feedback Signed-off-by: Adam Miller <admiller@redhat.com> * Refines changelog docs, minor re-org of page * moves links and anchors for new content * Further reorg of page * fixes header per jamescassell
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Miller admiller@redhat.com
SUMMARY
Add docs for developer guides about changelog fragments
ISSUE TYPE
COMPONENT NAME
docs
ANSIBLE VERSION