Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use state: latest for dpkg_selections test. #48696

Merged
merged 1 commit into from Nov 15, 2018
Merged

Use state: latest for dpkg_selections test. #48696

merged 1 commit into from Nov 15, 2018

Conversation

mattclay
Copy link
Member

SUMMARY

Use state: latest for dpkg_selections test.

We don't need to test with upgrade: dist, since we're not trying to test the apt module. We just need to make sure the hold set by the dpkg_selections module is working.

This change will avoid updating all the packages on the system, which is slow, unnecessary, and can cause the installed python to be changed.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

dpkg_selections integration test

@mattclay
Use state: latest for dpkg_selections test.
58bd371 
We don't need to test with `upgrade: dist`, since we're not trying
to test the `apt` module. We just need to make sure the hold set
by the `dpkg_selections` module is working.

This change will avoid updating all the packages on the system,
which is slow, unnecessary, and can cause the installed python
to be changed.
@ansibot
Copy link
Contributor

ansibot commented Nov 15, 2018

Hi @mattclay, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Nov 15, 2018
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Nov 15, 2018
@mattclay mattclay merged commit 136a2cc into ansible:devel Nov 15, 2018
@mattclay mattclay deleted the fix-dpkg_selections-test branch November 15, 2018 01:03
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattclay @ansibot @dagwieers