New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Spotinst Dynamic Inventory script and ini file #48741

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@jeffnoehren
Contributor

jeffnoehren commented Nov 15, 2018

SUMMARY

Adding a Dynamic inventory script and ini file for Spotinst

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Spotinst Dynamic Inventory

ansible -i spotinst.py -u ec2-user all -m ping

34.209.135.19 | SUCCESS => {
    "changed": false, 
    "ping": "pong"
}
@ansibot

This comment has been minimized.

Contributor

ansibot commented Nov 15, 2018

Hi @jeffnoehren, thank you for submitting this pull-request!

click here for bot help

@s-hertel

This comment has been minimized.

Contributor

s-hertel commented Dec 1, 2018

Have you thought about adding this as an inventory plugin instead? It allows flexible grouping, setting hostvars, and using a common infrastructure for caching. I don't think we're adding new contrib scripts. Here's some development documentation https://docs.ansible.com/ansible/latest/dev_guide/developing_inventory.html#developing-an-inventory-plugin.

@ansibot ansibot added the needs_repo label Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment