Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Spotinst Dynamic Inventory script and ini file #48741

Closed
wants to merge 1 commit into from
Closed

adding Spotinst Dynamic Inventory script and ini file #48741

wants to merge 1 commit into from

Conversation

jeffnoehren
Copy link
Contributor

SUMMARY

Adding a Dynamic inventory script and ini file for Spotinst

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Spotinst Dynamic Inventory

ansible -i spotinst.py -u ec2-user all -m ping

34.209.135.19 | SUCCESS => {
    "changed": false, 
    "ping": "pong"
}

@ansibot
Copy link
Contributor

ansibot commented Nov 15, 2018

Hi @jeffnoehren, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 c:inventory/contrib_script community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. inventory Inventory category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 15, 2018
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 15, 2018
@gundalow gundalow removed needs_triage Needs a first human triage before being processed. labels Nov 22, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 26, 2018
@s-hertel
Copy link
Contributor

s-hertel commented Dec 1, 2018

Have you thought about adding this as an inventory plugin instead? It allows flexible grouping, setting hostvars, and using a common infrastructure for caching. I don't think we're adding new contrib scripts. Here's some development documentation https://docs.ansible.com/ansible/latest/dev_guide/developing_inventory.html#developing-an-inventory-plugin.

@ansibot ansibot added the needs_repo This PR no longer has an associated branch as it was removed by the submitter. label Dec 1, 2018
@abadger
Copy link
Contributor

abadger commented Dec 14, 2018

Closing as the branch no longer exists. Assuming we're waiting for an inventory plugin PR to look at instead.

@abadger abadger closed this Dec 14, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 c:inventory/contrib_script community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. inventory Inventory category needs_repo This PR no longer has an associated branch as it was removed by the submitter. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants