Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for password_hash #48922

Closed
wants to merge 2 commits into from
Closed

Add integration test for password_hash #48922

wants to merge 2 commits into from

Conversation

Akasurde
Copy link
Member

SUMMARY
  • Tests for password_hash filter
  • Documentation update

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/user_guide/playbooks_filters.rst
lib/ansible/plugins/filter/core.py
test/integration/targets/filters/tasks/main.yml

@ansibot
Copy link
Contributor

ansibot commented Nov 20, 2018

Hi @Akasurde, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 20, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 20, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Nov 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 20, 2018

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_filters.rst:4:0: warning: Duplicate explicit target name: "passlib".

The test ansible-test sanity --test rstcheck [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_filters.rst:4:0: Duplicate explicit target name: "passlib".

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 20, 2018
@Akasurde Akasurde force-pushed the filter_test branch 2 times, most recently from e45f780 to 541da75 Compare November 21, 2018 04:57
@ansibot
Copy link
Contributor

ansibot commented Nov 21, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Nov 21, 2018
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Nov 27, 2018
@ansibot ansibot added docsite This issue/PR relates to the documentation website. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 5, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 14, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Dec 16, 2018
@mattclay
Copy link
Member

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/99126/44/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 19, 2018
@Akasurde
Add integration test for password_hash
4e26647 
* Tests for password_hash filter
* Documentation update

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Dec 20, 2018
@Akasurde
Fix CI failures
790b6c6 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 29, 2018
@Akasurde Akasurde closed this Feb 5, 2019
@Akasurde Akasurde deleted the filter_test branch April 15, 2019 04:47
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Akasurde @ansibot @mattclay @samdoran