Fix reboot plugin not working in Illumos/Solaris

[jpdasma]

SUMMARY

Using the reboot plugin under OpenIndiana results in the following error:

"msg": "Shutdown command failed. Error was /usr/sbin/shutdown: -r: unknown option\r\nUsage: /usr/sbin/shutdown [ -y ] [ -g ] [ -i ] [ message ], Shared connection to 192.168.122.146 closed.",

The issue is that the command being called is wrong (shutdown -y -g {delay_sec} -r "{message}") for Solaris/Illumos based system.
As specified here https://docs.oracle.com/cd/E23824_01/html/821-1451/gldpm.html and the manpages for OpenIndiana, there is no "-r" argument for shutdown. Also, based on the manpages, -i (init-state) defaults to single user mode, which means that the system would fail to start again.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

reboot.py

ADDITIONAL INFORMATION

By default, there is no whoami installed in OpenIndiana. This would make the DEFAULT_TEST_COMMAND to fail. Should I file an issue for this? Or could I fix this here?

[ansibot]

Hi @jpdasma, thank you for submitting this pull-request!

click here for bot help

[jpdasma]

rebased to retrigger build

[jpdasma]

Error in CI is not related to Solaris/Illumos.

[samdoran]

Thank you for reporting this. I'm curious which version of Solaris this is that doesn't have the -r flag. Can you give me the output of ansible [host] -m setup -a 'filter=ansible_distribution*'?

[jpdasma]

hi, i tested this on OpenIndiana. I think both should be the same as Solaris 11. (well at least based on Oracle's online man page). I'll deploy later a Solaris 11 VM to verify.

[jpdasma]

Tribblix (another Illumos distro) also doesn't have a "-r" as flags

[jpdasma]

Hi, seems I am wrong, Solarias 11 (at least 11.4) as the "-r" flag. For Illumos based, I have verified that OpenIndiana (Hipster 2018.10 version) still doesn't have a "-r" flag. Maybe they stuck with the old shutdown from Solaris 10? (Although I still haven't touch a Solaris 10 box)

Maybe a separate Illumos classification is needed?

[samdoran]

@jpdasma That aligns with my testing on Solaris 10 and Solaris 11. I tested on Solaris 11, but the command you suggest in this PR seems to work for Solaris 10. Can you test with #49272?

I would also appreciate the output of ansible [host] -m setup -a 'filter=ansible_distribution*' on the distributions you mention (OpenIndiana and Tribblix).

[jpdasma]

Hi, this is my result:

192.168.122.146 | SUCCESS => {
    "ansible_facts": {
        "ansible_distribution": "OpenIndiana"
    },
    "changed": false
}

This is for OpenIndiana, for Tribblix, I don't have access to the machine I tested at the moment.

[samdoran]

That is helpful. Could you add the * to the end so I can see version inforamation as well? Also, how about ansible [host] -m setup -a 'filter=ansible_os_family'?

[jpdasma]

This is for Tribblix
For ansible_distribution*:

192.168.122.112 | SUCCESS => {
    "ansible_facts": {
        "ansible_distribution": "SunOS", 
        "ansible_distribution_release": "5.11", 
        "ansible_distribution_version": "omnitribblix-m20.5"
    }, 
    "changed": false
}

For ansible_os_familty:

192.168.122.112 | SUCCESS => {
    "ansible_facts": {
        "ansible_os_family": "SunOS"
    }, 
    "changed": false
}

[jpdasma]

OmniOS and OpenIndiana:

192.168.122.146 | SUCCESS => {
    "ansible_facts": {
        "ansible_distribution": "OpenIndiana",
        "ansible_distribution_release": "OpenIndiana Hipster 2018.10 (powered by illumos)",
        "ansible_distribution_version": "illumos-c540c5554d"
    },
    "changed": false
}
omnios | SUCCESS => {
    "ansible_facts": {
        "ansible_distribution": "OmniOS",
        "ansible_distribution_release": "OmniOS v11 r151028d",
        "ansible_distribution_version": "r151028d"
    },
    "changed": false
}

192.168.122.146 | SUCCESS => {
    "ansible_facts": {
        "ansible_os_family": "Solaris"
    },
    "changed": false
}
omnios | SUCCESS => {
    "ansible_facts": {
        "ansible_os_family": "Solaris"
    },
    "changed": false
}

[samdoran]

Thank you. This is very helpful.

[samdoran]

@jpdasma Can you test with #49272? I believe I fixed the lack of whoami in OpenIndiana (and all Solaris versions) with that PR by using who instead. If that's not a universal enough command, feel free to suggest one that's appropriate for Solaris-based distributions. Thank you.

[jpdasma]

@samdoran working fine on my end thanks!