Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new module to support NIOS Fixedaddress DHCP property #49119

Merged
merged 9 commits into from Jan 4, 2019
Merged

Added new module to support NIOS Fixedaddress DHCP property #49119

merged 9 commits into from Jan 4, 2019

Conversation

justjais
Copy link
Contributor

SUMMARY

PR raised to add support for nios_fixed_address which was raised in issue #46121. Now, the user can add fixed-address for both ipv4/v6 as supported by NIOS object.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

nios

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

Hi @justjais, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @NilashishC @Qalthos @ganeshrn @gdpak @rcarrillocruz @sganesh-infoblox @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

The test ansible-test sanity --test pep8 [explain] failed with 9 errors:

lib/ansible/modules/net_tools/nios/nios_fixed_address.py:20:64: W291 trailing whitespace
lib/ansible/modules/net_tools/nios/nios_fixed_address.py:198:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/net_tools/nios/nios_fixed_address.py:212:1: E302 expected 2 blank lines, found 1
test/units/modules/net_tools/nios/test_nios_fixed_address.py:66:21: E203 whitespace before ':'
test/units/modules/net_tools/nios/test_nios_fixed_address.py:90:25: E203 whitespace before ':'
test/units/modules/net_tools/nios/test_nios_fixed_address.py:100:21: E203 whitespace before ':'
test/units/modules/net_tools/nios/test_nios_fixed_address.py:132:21: E203 whitespace before ':'
test/units/modules/net_tools/nios/test_nios_fixed_address.py:154:21: E203 whitespace before ':'
test/units/modules/net_tools/nios/test_nios_fixed_address.py:189:21: E203 whitespace before ':'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/net_tools/nios/nios_fixed_address.py:0:0: E323 "cidr" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 26, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 26, 2018
@Qalthos Qalthos removed needs_triage Needs a first human triage before being processed. networking Network category labels Nov 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 4, 2019

@justjais this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 4, 2019
@justjais
nios fixedaddr new module
aaba9ef 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
12e3ff8 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
36a665e 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
90247d6 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
37fa334 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
6ce109d 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
nios fixedaddr new module
9f08ecc 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
updating name
004502c 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
added unit tests
b4dc06f 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 4, 2019
@justjais justjais merged commit 189fcb3 into ansible:devel Jan 4, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@justjais @kbreit
Added new module to support NIOS Fixedaddress DHCP property (ansible#…
bee5ae9 
…49119)

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* nios fixedaddr new module

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* updating name

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added unit tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais deleted the fixedaddr branch January 16, 2019 08:19
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. net_tools Net-tools category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @ganeshrn @Qalthos