Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module for creating, managing Infoblox NIOS nameserver groups #49124

Merged
merged 5 commits into from Dec 20, 2018
Merged

New Module for creating, managing Infoblox NIOS nameserver groups #49124

merged 5 commits into from Dec 20, 2018

Conversation

justjais
Copy link
Contributor

SUMMARY

Module to create and manage Infoblox nameserver groups through the Wapi nsgroups objects. Closing the stale PR #35915 in which originally the new module was added, addressed the review comments and added Unit tests/integration tests for the respective modules.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

nios_nsgroup

ADDITIONAL INFORMATION

@justjais
adding new nios_nsgroup module
aab1d9c 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
adding new nios_nsgroup module
a8195e6 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
adding new nios_nsgroup module
45b16d8 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais mentioned this pull request Nov 26, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

Hi @justjais, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

cc @NilashishC @Qalthos @ganeshrn @gdpak @rcarrillocruz @sganesh-infoblox @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 26, 2018
@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/net_tools/nios/nios_nsgroup.py:336:0: missing-final-newline Final newline missing

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/net_tools/nios/nios_nsgroup.py:19:8: W291 trailing whitespace
lib/ansible/modules/net_tools/nios/nios_nsgroup.py:64:83: W291 trailing whitespace
lib/ansible/modules/net_tools/nios/nios_nsgroup.py:336:11: W292 no newline at end of file

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 26, 2018
@justjais
fix shippable errors
17d96ab 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
added unit tests
acc10d5 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais mentioned this pull request Nov 27, 2018
Closed
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Nov 27, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 5, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 20, 2018
@justjais justjais merged commit f76d7bd into ansible:devel Dec 20, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@justjais @kbreit
New Module for creating, managing Infoblox NIOS nameserver groups (an…
fd16f6e 
…sible#49124)

* adding new nios_nsgroup module

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding new nios_nsgroup module

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding new nios_nsgroup module

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable errors

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* added unit tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais deleted the nios_nsg branch January 16, 2019 08:20
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@Qalthos Qalthos Awaiting requested review from Qalthos

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. infoblox Infoblox NIOS module This issue/PR relates to a module. net_tools Net-tools category networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justjais @ansibot @ganeshrn