Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added handlers_from #49220

Merged
merged 4 commits into from Dec 18, 2018
Merged

added handlers_from #49220

merged 4 commits into from Dec 18, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Nov 28, 2018

fixes #46769

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

include_role/import_role

@ansibot
Copy link
Contributor

ansibot commented Nov 28, 2018

Hi @bcoca, thank you for submitting this pull-request!

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. include_role module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 28, 2018
@bcoca bcoca added this to To Do - Backlog only. Anything Can be here. in Ansible 2.8 Nov 28, 2018
@sivel sivel self-requested a review December 4, 2018 19:44
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 4, 2018
sivel
sivel approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@sivel sivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a changelog and likely a test.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 11, 2018
maxamillion
maxamillion approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll echo @sivel here with a request for tests and changelog but LGTM. 👍

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 14, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 15, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2018
@maxamillion
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 17, 2018
@bcoca bcoca merged commit 88c87a3 into ansible:devel Dec 18, 2018
@bcoca bcoca deleted the handlers_from branch December 18, 2018 16:28
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@bcoca @kbreit
added handlers_from (ansible#49220)
7d5965c 
* added handlers_from

fixes ansible#46769
@sivel sivel moved this from To Do - Backlog only. Anything Can be here. to Done - This means done, tests, integration, everything... obvi. in Ansible 2.8 Jan 29, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@maxamillion maxamillion maxamillion approved these changes

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. include_role module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Ansible 2.8
  
Done - This means done, tests, integr...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'handlers_from' option to import_role and include_role
6 participants
@bcoca @ansibot @maxamillion @sivel @mkrizek @samdoran