Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reboot - Fix command not found, add Apline support, fix Solaris command #49272

Merged
merged 3 commits into from Dec 11, 2018

Commits on Dec 6, 2018

  1. Fix various bugs related in reboot

    - Use format strings for consistency and improve debug log messages
    - Use local variables instead of class attributes in order to be thread safe
    - Run setup module to get distribution and version
    - Run find module to get full path of shutdown command
    - Use ansible_os_family and ansible_distribution to find commands and args
    - Use same command for all Solaris/SunOS distributions
    - Move delay calculations to properties
    - Reliably check for module run failure
    - Fix bug in run_test_command() that accidentally made the method work properly
    - Use better exceptions rather than Exception
    - Use dict literals rather than constructors
    - Correct _check_delay() so it always returns a value, not None
    - Don't store and return result in run_test_command() because it's not used anywhere
    samdoran committed Dec 6, 2018
    Copy the full SHA
    58599c5 View commit details
    Browse the repository at this point in the history
  2. Improve tests

    - add test for post reboot command that fails
    - test negative values for delay parameters
    samdoran committed Dec 6, 2018
    Copy the full SHA
    1181a33 View commit details
    Browse the repository at this point in the history
  3. Add changelog

    samdoran committed Dec 6, 2018
    Copy the full SHA
    174464d View commit details
    Browse the repository at this point in the history