Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.7/48933 #49400

Merged
merged 2 commits into from Dec 4, 2018
Merged

Backport/2.7/48933 #49400

merged 2 commits into from Dec 4, 2018

Conversation

gundalow
Copy link
Contributor

@gundalow gundalow commented Dec 1, 2018

SUMMARY

Comparing provided password parameter against returned entity password breaks idempotency as storage_connections_service() returns passwords as NoneType.

#48933

cherry-picked from: 5cd3157

ISSUE TYPE
  • Bugfix Pull Request

@ansibot
Copy link
Contributor

ansibot commented Dec 1, 2018

Hi @gundalow, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 1, 2018

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) support:community This issue/PR relates to code supported by the Ansible community. labels Dec 1, 2018
@machacekondra
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Dec 3, 2018
mwperina
mwperina approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@abadger abadger merged commit 69e1d0f into ansible:stable-2.7 Dec 4, 2018
@abadger
Copy link
Contributor

abadger commented Dec 4, 2018

Merged for 2.7.5.

@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gundalow @ansibot @machacekondra @abadger @mwperina @dagwieers @bverschueren