Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Module - digital_ocean_projects_facts #49411

Closed
wants to merge 16 commits into from
Closed

New Module - digital_ocean_projects_facts #49411

wants to merge 16 commits into from

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Dec 2, 2018 •
edited

SUMMARY

New module displays facts about DigitalOcean projects.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

digital_ocean_projects_facts

@kbreit
Initial commit for module
1016b1c 
- Haven't tested, query only
@kbreit
- Added integration test, which isn't actually right
c8709ac
@kbreit
"Finish" module, with exception of documentation
ac9d372 
- Full functionality for facts module
- Integration test, still pending main module for full operation
@ansibot
Copy link
Contributor

ansibot commented Dec 2, 2018

Hi @kbreit, thank you for submitting this pull-request!

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Dec 2, 2018

cc @BondAnthony @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. digital_ocean module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 2, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:163:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E323 "description" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E323 "environment" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E323 "purpose" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E323 "state" is listed in DOCUMENTATION.options, but not accepted by the module
lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E325 argument_spec for "resources" defines type="bool" but documentation does not

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 3, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:0:0: E323 "state" is listed in DOCUMENTATION.options, but not accepted by the module

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 3, 2018
@kbreit
Added return documentation
2be2d0e 
- Added return documentation, heavily using content from official DO
documentation
@kbreit
Fix corner case where resource is False
aadc092
@ansibot
Copy link
Contributor

ansibot commented Dec 4, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:169:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:141:21: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/digital_ocean/digital_ocean_project_facts.py:141:21: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Dec 4, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 19, 2019
@kbreit
Move test from legacy to modern integration framework
a17ab5b 
- Also modified the documentation very slightly
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/digital_ocean_project_facts/aliases:0:0: missing alias `shippable/posix/group[1-3]` or `unsupported`

click here for bot help

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 20, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jan 21, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 25, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2019

cc @aluvenko @mgregson
click here for bot help

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 6, 2019
@kbreit
Copy link
Contributor Author

kbreit commented Feb 27, 2019

@gundalow Changes were integrated. Please review.

@ansibot ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 27, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Mar 7, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels May 2, 2019
@kbreit
Copy link
Contributor Author

kbreit commented Sep 3, 2019

This should be changed to be an info module.

@kbreit
Copy link
Contributor Author

kbreit commented Oct 20, 2019

Since this has been sitting a while and it doesn't seem like Digital Ocean modules are in development, I'm going to close this for now.

@kbreit kbreit closed this Oct 20, 2019
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
@kbreit kbreit deleted the digital_ocean/digital_ocean_projects_facts branch November 28, 2019 20:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud digital_ocean module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kbreit @ansibot @gundalow @mattclay @samdoran