New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multiple values for single key in cmdline facts #49591

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@Akasurde
Member

Akasurde commented Dec 6, 2018

SUMMARY
  • Facts parsing for cmdline can now handle multiple values for a single key.
  • Unit tests for cmdline fact parsing

Fixes: #22766

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/22766-fact-cmdline-return_multiple_lvm_values.yaml
lib/ansible/module_utils/facts/system/cmdline.py
test/units/module_utils/facts/system/test_cmdline.py

Parse multiple values for single keys in cmdline facts
* Facts parsing for cmdline can now handle multiple values for a single key.
* Unit tests for cmdline fact parsing

Fixes: #22766

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde changed the title from Parse multiple values for single keys in cmdline facts to Parse multiple values for single key in cmdline facts Dec 6, 2018

@samdoran samdoran removed the needs_triage label Dec 11, 2018

@bcoca

This should be a new key, not give 2 diff results on same one, leave current as is and create new fact that always returns this as a list, then we can deal with deprecating/removing the current fact.

@ansibot ansibot added needs_revision and removed core_review labels Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment