Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse multiple values for single key in cmdline facts #49591

Merged
merged 2 commits into from Feb 19, 2019
Merged

Parse multiple values for single key in cmdline facts #49591

merged 2 commits into from Feb 19, 2019
+98 −0

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Dec 6, 2018

SUMMARY
  • Facts parsing for cmdline can now handle multiple values for a single key.
  • Unit tests for cmdline fact parsing

Fixes: #22766

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/22766-fact-cmdline-return_multiple_lvm_values.yaml
lib/ansible/module_utils/facts/system/cmdline.py
test/units/module_utils/facts/system/test_cmdline.py

@Akasurde Akasurde changed the title Parse multiple values for single keys in cmdline facts Parse multiple values for single key in cmdline facts Dec 6, 2018
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 6, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 11, 2018
bcoca
bcoca requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a new key, not give 2 diff results on same one, leave current as is and create new fact that always returns this as a list, then we can deal with deprecating/removing the current fact.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 11, 2018
@mattclay
Copy link
Member

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/99138/9/tests

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Dec 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Feb 12, 2019

cc @acozine
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 12, 2019
@Akasurde
Copy link
Member Author

@bcoca Could you please take another look into this ? Thanks.

@Akasurde
Parse multiple values for single keys in cmdline facts
dc729d4 
* Facts parsing for cmdline can now handle multiple values for a single key.
* Unit tests for cmdline fact parsing

Fixes: ansible#22766

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde
Review comments
c16db8a 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 18, 2019
@Akasurde Akasurde merged commit 57d8503 into ansible:devel Feb 19, 2019
@Akasurde Akasurde deleted the i22766 branch February 19, 2019 10:17
@Akasurde Akasurde mentioned this pull request Mar 25, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible facts: ansible_cmdline return incorrect result for the rd.lvm.lv
5 participants
@Akasurde @mattclay @ansibot @bcoca @samdoran