Support for generalizing VMs #49704
Merged
Support for generalizing VMs #49704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
added 2 commits
December 10, 2018 12:26
added 2 commits
December 10, 2018 12:35
yungezz
reviewed
Dec 10, 2018
| @@ -68,6 +68,12 @@ | |||
| - Toggle that controls if the machine is allocated/deallocated, only useful with state='present'. | |||
| default: True | |||
| type: bool | |||
| generalized: | |||
There was a problem hiding this comment.
it follows other options, which are "started", "stopped".... etc....
| @@ -1343,6 +1359,9 @@ def serialize_vm(self, vm): | |||
| if vm.instance_view: | |||
| result['powerstate'] = next((s.code.replace('PowerState/', '') | |||
| for s in vm.instance_view.statuses if s.code.startswith('PowerState')), None) | |||
| for s in vm.instance_view.statuses: | |||
| if s.code == "OSState/generalized": | |||
There was a problem hiding this comment.
lower case to avoid case sensitive?
ansibot
removed
the
needs_triage
yungezz
reviewed
Dec 10, 2018
| generalized: | ||
| description: | ||
| - Use with state 'present' to generalize the machine. Set to true to generalize the machine. | ||
| - Please note that this operation is irreversible. |
There was a problem hiding this comment.
i think we need stronger message to user, that once generalized, the vm is not usable.
yungezz
approved these changes
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR extends current VM to support generalization.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine
azure_rm_virtualmachine_facts
ADDITIONAL INFORMATION