Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ansible UTM Module for managing network aaa entries. #49863

Closed
wants to merge 2 commits into from
Closed

Added Ansible UTM Module for managing network aaa entries. #49863

wants to merge 2 commits into from

Conversation

maunzCache
Copy link
Contributor

SUMMARY

This PR will add a new utm module which allows the management of network aaa entries of the Sophos UTM. This module integrates with the existing utm_utils .

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • module/web_infrastructure/sophos_utm/utm_network_aaa.py

@ansibot
Copy link
Contributor

ansibot commented Dec 13, 2018

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 13, 2018
  - Fixed documentation trailing whitespaces
  - Added missing documentation
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 13, 2018
@MatrixCrawler
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Dec 13, 2018

Components

lib/ansible/modules/web_infrastructure/sophos_utm/utm_network_aaa.py
support: community
maintainers: MatrixCrawler getjack

Metadata

waiting_on: getjack
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: failure
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 22, 2018

@MatrixCrawler @stearz

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 22, 2018
@stearz
Copy link

stearz commented Dec 24, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 24, 2018
module: utm_network_aaa

author:
- Stephan Schwarz (@stearz)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to your name

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry? This is my name. What am I missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other PR. @stearz did the code but i commited it in his name so he is the author. We're working colleagues and i was reviewing the code.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed shipit This PR is ready to be merged by Core new_contributor This PR is the first contribution by a new community member. labels Jan 11, 2019
@maunzCache
Copy link
Contributor Author

I am very sorry but i deleted the remote repo and i didn't check the PRs beforehand. Will redo the PRs and fix it. Sorry for the overhead :(

@maunzCache maunzCache closed this Feb 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants