Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix_host_facts: get list of templates #50007

Merged
merged 1 commit into from Jan 9, 2019
Merged

zabbix_host_facts: get list of templates #50007

merged 1 commit into from Jan 9, 2019

Conversation

mindrb
Copy link
Contributor

@mindrb mindrb commented Dec 17, 2018 •
edited

SUMMARY

Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zabbix_host_facts

ADDITIONAL INFORMATION

@mindrb
zabbix_host_facts: get list of templates
1aab6ed 
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
@ansibot
Copy link
Contributor

ansibot commented Dec 17, 2018

cc @D3DeFi @eikef @RedWhiteMiko
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 17, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Dec 18, 2018
@abadger abadger mentioned this pull request Dec 18, 2018
Closed
@gundalow
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Dec 18, 2018

Components

lib/ansible/modules/monitoring/zabbix/zabbix_host_facts.py
support: core
maintainers: D3DeFi eikef redwhitemiko

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

D3DeFi
D3DeFi approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with all LTS releases of zabbix server, works fine :)

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 20, 2018

shipit

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 20, 2018

@RedWhiteMiko are you ok with these changes?

@RedWhiteMiko
Copy link
Contributor

RedWhiteMiko commented Dec 26, 2018 •
edited by resmo

LGTM

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 26, 2018
@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 26, 2018

bot_status

@ansibot
Copy link
Contributor

ansibot commented Dec 26, 2018

Components

lib/ansible/modules/monitoring/zabbix/zabbix_host_facts.py
support: core
maintainers: D3DeFi eikef redwhitemiko

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): D3DeFi
shipit_actors_other: RedWhiteMiko
automerge: automerge shipit test failed

click here for bot help

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 27, 2018

If I am not mistaken, labels core_review and support:core are blocking this PR from being merged. Probably related to linked PR about 'component wasn't properly found'.

@mindrb can you please try to remove word 'module' present in COMPONENT NAME section in this PR's description and leave just 'zabbix_host_facts' there? When you are done, please close this PR and then reopen it to force ansibot to look once again :)

@mindrb mindrb closed this Dec 27, 2018
@mindrb mindrb reopened this Dec 27, 2018
@mindrb
Copy link
Contributor Author

mindrb commented Dec 27, 2018

@D3DeFi done

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 27, 2018
@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 27, 2018 •
edited

-label core_review
+label community_review

@D3DeFi
Copy link
Contributor

D3DeFi commented Dec 28, 2018

since this PR got your attention, can I ask for your help @gundalow? Is there any way to get it moving by ourselves or we simply just need a review from a core dev?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 5, 2019
@resmo
Copy link
Contributor

resmo commented Jan 9, 2019

hi all, this should get merged by the bot without core members interaction. We are still investigating why it didnt and keep this open for analysis purposes. But assume this to be merged. Thanks.

@resmo
Copy link
Contributor

resmo commented Jan 9, 2019

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2019

Components

lib/ansible/modules/monitoring/zabbix/zabbix_host_facts.py
support: core
maintainers: D3DeFi eikef redwhitemiko

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): D3DeFi
shipit_actors_other: RedWhiteMiko
automerge: automerge shipit test failed

click here for bot help

@resmo resmo mentioned this pull request Jan 9, 2019
Merged
@resmo
Copy link
Contributor

resmo commented Jan 9, 2019

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2019

Components

lib/ansible/modules/monitoring/zabbix/zabbix_host_facts.py
support: core
maintainers: D3DeFi RedWhiteMiko eikef

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): D3DeFi RedWhiteMiko
shipit_actors_other: []
automerge: automerge ci_stale test failed

click here for bot help

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 9, 2019
@resmo
Copy link
Contributor

resmo commented Jan 9, 2019

looks much better know, but I still wonder why core_review labeled. however,

rebuild_merge

@D3DeFi
Copy link
Contributor

D3DeFi commented Jan 9, 2019

thanks @resmo ! :)

@ansibot ansibot merged commit 260285a into ansible:devel Jan 9, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@mindrb @kbreit
zabbix_host_facts: get list of templates (ansible#50007)
13904da 
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@mindrb @knumskull
zabbix_host_facts: get list of templates (ansible#50007)
38b5156 
Get list of templates among other items. It is useful because later one can edit this list using zabbix_host module.
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@D3DeFi D3DeFi D3DeFi approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mindrb @ansibot @gundalow @D3DeFi @RedWhiteMiko @resmo @dagwieers @jborean93