Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unknown error to specific error message #50129

Merged
merged 2 commits into from Dec 20, 2018
Merged

Update Unknown error to specific error message #50129

merged 2 commits into from Dec 20, 2018

Conversation

warusadura
Copy link
Contributor

@warusadura warusadura commented Dec 19, 2018 •
edited

SUMMARY

Outputs the Exception received rather than just 'Unknown error'

before:

fatal: [HOST]: FAILED! => {"changed": false, "msg": "Unknown error"}

after:

fatal: [HOST]: FAILED! => {"changed": false, "msg": "Failed GET operation against Redfish API server: invalid literal for int() with base 10: ''"}

fixes: #49713

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_facts

@warusadura
Update Unknown error to specific error message
041c469 
outputs the Exception received rather than just 'Unknown error'
fixes: issue/49713
@warusadura warusadura mentioned this pull request Dec 19, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

cc @billdodd @jose-delarosa @mraineri @tomasg2012
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 19, 2018
@warusadura
Copy link
Contributor Author

I'm not sure why the CI tests failed. seems like a timeout. Is there a way I could re run the CI tests.

@mattclay
Copy link
Member

I've restarted the failed CI jobs.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Dec 19, 2018
@warusadura
Copy link
Contributor Author

@mattclay Thank you :)

@gundalow gundalow mentioned this pull request Dec 19, 2018
Closed
@Shaps
Copy link
Contributor

Shaps commented Dec 19, 2018

Not a redfish_utils module user, but the change looks ok to me

billdodd
billdodd approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@billdodd billdodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @dnuka. Fix looks good.

shipit

@warusadura
Copy link
Contributor Author

@bcoca Thank you for the review. Requested changes applied :)

@warusadura
Copy link
Contributor Author

warusadura commented Dec 19, 2018 •
edited

@billdodd
can you please recheck the new changes :)

billdodd
billdodd approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@billdodd billdodd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good. Thanks.

shipit

@jose-delarosa
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 19, 2018
@gundalow gundalow merged commit 44e2cbe into ansible:devel Dec 20, 2018
@warusadura warusadura deleted the issue/49713 branch January 9, 2019 05:36
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@warusadura @kbreit
Update Unknown error to specific error message (ansible#50129)
3f3cc80 
* Update `Unknown error` to specific error message

outputs the Exception received rather than just 'Unknown error'
fixes: issue/49713

* Update `Unknown error` to specific error message

improves the error message
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca left review comments

@billdodd billdodd billdodd approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redfish_facts results an Unknown error
8 participants
@warusadura @ansibot @mattclay @Shaps @jose-delarosa @bcoca @billdodd @gundalow