Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

influxdb_user: Fixed unhandled exception on invalid login credentials #50134

Merged
merged 1 commit into from Dec 20, 2018
Merged

influxdb_user: Fixed unhandled exception on invalid login credentials #50134

merged 1 commit into from Dec 20, 2018

Conversation

mdrose
Copy link
Contributor

@mdrose mdrose commented Dec 19, 2018

SUMMARY

Fixes #50131

Catches invalid authentication errors when searching for users and exits properly.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

influxdb_user

@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

cc @kamsz @zhhuta
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Dec 19, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Dec 19, 2018
gundalow
gundalow approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, looks good

@winem
Copy link
Contributor

winem commented Dec 19, 2018 •
edited

There are no negative tests at all for this module. I would love to see some negative tests - and volunteer to do this during christmas holidays although the error message is pretty descriptive already.

resmo
resmo approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo
Copy link
Contributor

resmo commented Dec 19, 2018

I would be okay, to merge now and would appreciate your PR for extended test use cases. @gundalow ?

@gundalow gundalow merged commit bcae7f2 into ansible:devel Dec 20, 2018
@mdrose mdrose deleted the invalid-auth-fix branch December 21, 2018 18:21
@mdrose mdrose mentioned this pull request Dec 25, 2018
Merged
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@mdrose @kbreit
influxdb_user: Fixed unhandled exception on invalid login credentials (…
e5ebe13 
…ansible#50134)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Influxdb_user yields an unhandled exception when presented with invalid login credentials
5 participants
@mdrose @ansibot @winem @resmo @gundalow