Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert range change #50155

Merged
merged 2 commits into from Dec 19, 2018
Merged

Revert range change #50155

merged 2 commits into from Dec 19, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Dec 19, 2018 •
edited

Previous change had been flagged for reverting but was missed and new docs reflect the incorrect behaviour.

reverts #50137 as it describes the behaviour we were supposed to have reverted from #27215

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

filters/random

@bcoca
Revert "Fix incorrect examples with random filter (ansible#50137)"
72c9f53 
This reverts commit 9a7dbd5.

The correction is incomplete and also based on a 'fix' that was supposed to have been reverted already
@bcoca
Revert "Added +1 to the end in random filter so that it was inc…
c86197e 
…lusive (ansible#27215)"

This reverts commit ea2b89c.

reverted fix as agreed at the time, but missed by maintainers.
@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 19, 2018
@maxamillion maxamillion merged commit b0c28f8 into ansible:devel Dec 19, 2018
@bcoca bcoca deleted the revert_range_change branch December 19, 2018 17:37
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@bcoca @kbreit
Revert range change (ansible#50155)
68d471d 
* Revert "Fix incorrect examples with random filter (ansible#50137)"

This reverts commit 9a7dbd5.

The correction is incomplete and also based on a 'fix' that was supposed to have been reverted already

* Revert "Added `+1` to the `end` in `random` filter so that it was inclusive (ansible#27215)"

This reverts commit ea2b89c.

reverted fix as agreed at the time, but missed by maintainers.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @ansibot @maxamillion