Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: vultr: convert legacy tests to targets #50156

Merged
merged 5 commits into from Jan 7, 2019
Merged

tests: vultr: convert legacy tests to targets #50156

merged 5 commits into from Jan 7, 2019

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Dec 19, 2018 •
edited

SUMMARY

convert the legacy tests to targets and add docs.
/cc @Spredzy

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

test

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

@resmo This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. labels Dec 19, 2018
@resmo resmo changed the title WIP: tests: vultr: convert legacy tests to targets tests: vultr: convert legacy tests to targets Dec 19, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 19, 2018
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jan 7, 2019
@resmo
Copy link
Contributor Author

resmo commented Jan 7, 2019

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 7, 2019

Components

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: True
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): resmo
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Jan 7, 2019
@resmo resmo merged commit 48ffe2f into ansible:devel Jan 7, 2019
@resmo resmo deleted the feature/mv-vultr-test-to-targets branch January 7, 2019 21:23
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 7, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@resmo @kbreit
tests: vultr: convert legacy tests to targets (ansible#50156)
416a3f4
@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@resmo @ansibot @sivel @dagwieers