postgresql_idx: misc fixes #50199
Merged
postgresql_idx: misc fixes #50199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed unused import * Removed 'login_password' from exit_json call * Removed unused db, cond variable Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
affects_2.8
Andersson007
approved these changes
Dec 21, 2018
| @@ -17,7 +17,7 @@ | |||
| DOCUMENTATION = r''' | |||
| --- | |||
| module: postgresql_idx | |||
| short_description: Creates or drops indexes from a PostgreSQL database. | |||
There was a problem hiding this comment.
See short descriptions of other modules. Most of them ends by ".", e.g. shell_module, postgresql_db, postgresql_user, etc.
Ok, it doesn't matter but I prefer sentences that end with "." )
| @@ -127,7 +127,7 @@ | |||
| idxname: test_gist_idx | |||
|
|
|||
| # Create gin index gin0_idx not concurrently on column comment of table test | |||
| # (Note: pg_trgm extention must be installed for gin_trgm_ops) | |||
|
shipit |
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
removed
the
needs_triage
Andersson007
approved these changes
Dec 21, 2018
|
@Andersson007 Thanks for the reviews. |
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* Removed unused import * Removed 'login_password' from exit_json call * Removed unused db, cond variable Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/database/postgresql/postgresql_idx.py