Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ansible_kubectl_ssl_ca_cert variable #50217

Merged
merged 2 commits into from Dec 23, 2018
Merged

fix: ansible_kubectl_ssl_ca_cert variable #50217

merged 2 commits into from Dec 23, 2018

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Dec 20, 2018 •
edited

SUMMARY

Fix for ansible_kubectl_ssl_ca_cert variable.
There was specified ansible_kubectl_cert_file by mistake

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubectl and oc connection modules

ADDITIONAL INFORMATION

@kvaps kvaps changed the title fix: mistake for ansible_kubectl_ssl_ca_cert variable fix: ansible_kubectl_ssl_ca_cert variable Dec 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

cc @chouseknecht @fabianvf @flaper87 @maxamillion @willthames
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 20, 2018
resmo
resmo approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 21, 2018
@fabianvf
Copy link
Contributor

shipit

1 similar comment
@resmo
Copy link
Contributor

resmo commented Dec 23, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 23, 2018
@resmo resmo merged commit 344b600 into ansible:devel Dec 23, 2018
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@kvaps @kbreit
fix: ansible_kubectl_ssl_ca_cert variable (ansible#50217)
f7abbd4 
* fix: mistake for ansible_kubectl_ssl_ca_cert variable

* fix: K8S_AUTH_VERIFY_SSL
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kvaps @ansibot @fabianvf @resmo