Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn private dependencies #50236

Closed
wants to merge 3 commits into from

Conversation

sdyroff
Copy link

@sdyroff sdyroff commented Dec 21, 2018

SUMMARY

This fixes multiple issues of the yarn module.

  • The yarn.list() method did not work with private npm dependencies which start with @
  • The check if a package.json is already in the defined path is not necessary, as yarn creates a package.json if necessary
  • Do not fail the module if all errors retrieved from yarn are warnings
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yarn

ADDITIONAL INFORMATION

We would like to use the yarn module to install private dependencies in an empty directory. This works only if the above issues are fixed.

@sdyroff
Copy link
Author

sdyroff commented Dec 21, 2018

@verkaufer
@chrishoffman

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 29, 2018
@sdyroff sdyroff force-pushed the fix_yarn_private_dependencies branch from 9fa1a15 to 2a61c93 Compare January 7, 2019 11:04
@sdyroff
Copy link
Author

sdyroff commented Jan 7, 2019

I rebased and updated my PR

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 7, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 15, 2019
@martin-probst
Copy link

+1

@ansibot ansibot added the packaging Packaging category label Feb 22, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@duck-rh
Copy link

duck-rh commented May 18, 2020

I confirm the problem with private dependencies is fixed. I also stumbled onto the package.json problem and the code for this part looks fine. I don't think I hit the problem with the warnings but the code looks fine too.

@ansibot
Copy link
Contributor

ansibot commented Aug 15, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 15, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 17, 2020
@ansible ansible locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bot_closed bug This issue/PR relates to a bug. collection:community.general collection Related to Ansible Collections work module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. packaging Packaging category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants