Fix firewalld module failing on missing protocol.

[ericzolf]

SUMMARY

Under Python 3.7 at least, the split of the port field fails
ungracefully if there is no slash. The fix also addresses the
case of an empty protocol after the slash.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

firewalld

ADDITIONAL INFORMATION

if giving the port as 12345 (without e.g. /tcp) the following error would be spit out:

  import imp
Traceback (most recent call last):
  File \"/home/myuser/.ansible/tmp/ansible-tmp-1545383532.7414896-43532312250195/AnsiballZ_firewalld.py\", line 113, in <module>
    _ansiballz_main()
  File \"/home/myuser/.ansible/tmp/ansible-tmp-1545383532.7414896-43532312250195/AnsiballZ_firewalld.py\", line 105, in _ansiballz_main
    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
  File \"/home/myuser/.ansible/tmp/ansible-tmp-1545383532.7414896-43532312250195/AnsiballZ_firewalld.py\", line 48, in invoke_module
    imp.load_module('__main__', mod, module, MOD_DESC)
  File \"/usr/lib64/python3.7/imp.py\", line 234, in load_module
    return load_source(name, filename, file)
  File \"/usr/lib64/python3.7/imp.py\", line 169, in load_source
    module = _exec(spec, sys.modules[name])
  File \"<frozen importlib._bootstrap>\", line 630, in _exec
  File \"<frozen importlib._bootstrap_external>\", line 728, in exec_module
  File \"<frozen importlib._bootstrap>\", line 219, in _call_with_frames_removed
  File \"/tmp/ansible_firewalld_payload_6m_d8c8n/__main__.py\", line 715, in <module>
  File \"/tmp/ansible_firewalld_payload_6m_d8c8n/__main__.py\", line 570, in main
ValueError: not enough values to unpack (expected 2, got 1)

The fix also makes sure that an empty protocol e.g. 12345/ isn't accepted anymore.

[ansibot]

cc @maxamillion
click here for bot help

[evgeni]

👍 (but I have no review powers here)

[maxamillion]

@ericzolf thank you for the fix!