Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AttributeError in network_cli #50284

Merged
merged 1 commit into from Dec 23, 2018
Merged

Conversation

ganeshrn
Copy link
Member

SUMMARY
  • Value of prompt_answer is wrongly used as self.prompt_answer
    while logging it in message queue
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/connection/network_cli.py

ADDITIONAL INFORMATION

*  Value of prompt_answer is wrongly used as `self.prompt_answer`
   while logging it in message queue
@ansibot
Copy link
Contributor

ansibot commented Dec 23, 2018

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Dec 23, 2018
@ganeshrn ganeshrn removed the needs_triage Needs a first human triage before being processed. label Dec 23, 2018
@ganeshrn ganeshrn merged commit 104c415 into ansible:devel Dec 23, 2018
@ganeshrn ganeshrn deleted the network_cli_fix branch December 23, 2018 19:32
@abenokraitis
Copy link
Contributor

I think this is small enough to warrant a backport to 2.7 as this will assist current deployments.

@Qalthos
Copy link
Contributor

Qalthos commented Jan 8, 2019

@abenokraitis No need, the issue is not in 2.7 (and is part of #50028 which definitely is too big to backport)

kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
*  Value of prompt_answer is wrongly used as `self.prompt_answer`
   while logging it in message queue
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants