Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fortinet FortiManager Connection Plugin RC, plus associated utilities #50336
A while back, we were asked by @gdpak to re-write our modules to use the new httpapi plugin method. We have done so. This is our first PR/RC for the FortiManager Ansible Connection Plugin.
Please find the plugin file, as well as changes to module_utils/fortimanager.py, and the addition of module_utils/common.py.
Modules to run this on, are available on request. We have already converted all existing modules to these new plugins and tools, so we're ready to go.
Please note that backwards compatibility with module_utils/fortimanager.py is maintained for older modules, or older versions of Ansible, or for customers who don't want to upgrade to the new plugin.
module_utils/network/fortimanager/common.py -- A lib of common procedures and static methods.
referenced this pull request
Dec 29, 2018
Hi @gdpak - We've rewritten our modules to work with the new plugin standards. Please review our changes and let us know what you think. We need to have this reviewed and pushed through the PR so that we can go back and change all of our existing FortiManager modules to use this new code. Thanks!
Hi @gundalow May you please help us with this PR? This PR is critical for us to continue pushing new modules for our Fortinet products. Please let us know the next steps, even if it is simply assigning a reviewer to this PR.
Thank you for your time and help!
left a comment
I'm not too familiar with how FortiMnager works presently, so I've tried to review the HttpApi plugin based on how things have been done with other such plugins. Feel free to let me know if I've overlooked something or failed to explain something adequately.
@Qalthos We’ve updated the code to address your comments. Please provide feedback at your earliest convienence so we can finish this month long PR. It is holding up the rest of our module submissions. We’d like to resolve this as soon as possible. Thanks.