New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet FortiManager Connection Plugin RC, plus associated utilities #50336

Open
wants to merge 6 commits into
base: devel
from

Conversation

@ftntcorecse
Copy link
Contributor

ftntcorecse commented Dec 27, 2018

SUMMARY

A while back, we were asked by @gdpak to re-write our modules to use the new httpapi plugin method. We have done so. This is our first PR/RC for the FortiManager Ansible Connection Plugin.

Please find the plugin file, as well as changes to module_utils/fortimanager.py, and the addition of module_utils/common.py.

Modules to run this on, are available on request. We have already converted all existing modules to these new plugins and tools, so we're ready to go.

Please note that backwards compatibility with module_utils/fortimanager.py is maintained for older modules, or older versions of Ansible, or for customers who don't want to upgrade to the new plugin.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

module_utils/network/fortimanager/common.py -- A lib of common procedures and static methods.
module_utils/network/fortimanager/fortimanager.py -- Updated to provide tools to work with the new connection plugin, as well as static code used throughout modules.

ADDITIONAL INFORMATION

@ftntcorecse ftntcorecse changed the title PR Candidate for FortiManager Connection Plugin, plus associated utilities Fortinet FortiManager Connection Plugin RC, plus associated utilities Dec 27, 2018

@ansibot ansibot added needs_revision and removed core_review labels Dec 27, 2018

Update fortimanager.py
Adding additional comments

@ansibot ansibot added core_review and removed needs_revision labels Jan 4, 2019

@Ghilli3

This comment has been minimized.

Copy link
Contributor

Ghilli3 commented Jan 5, 2019

@gundalow Hi John, we have rewritten our code to adhere to your new requested standards of using plugins. Please let us know how this looks and how we can move forward with moving this code through.

@ansibot ansibot removed the needs_triage label Jan 5, 2019

@Ghilli3

This comment has been minimized.

Copy link
Contributor

Ghilli3 commented Jan 7, 2019

Hi @gdpak - We've rewritten our modules to work with the new plugin standards. Please review our changes and let us know what you think. We need to have this reviewed and pushed through the PR so that we can go back and change all of our existing FortiManager modules to use this new code. Thanks!

@ftntcorecse

This comment has been minimized.

Copy link
Contributor

ftntcorecse commented Jan 10, 2019

Hi @gundalow May you please help us with this PR? This PR is critical for us to continue pushing new modules for our Fortinet products. Please let us know the next steps, even if it is simply assigning a reviewer to this PR.

Thank you for your time and help!

@ansibot ansibot added the stale_ci label Jan 14, 2019

@abenokraitis abenokraitis added this to Needs Triage in Networking via automation Jan 14, 2019

@Qalthos
Copy link
Contributor

Qalthos left a comment

I'm not too familiar with how FortiMnager works presently, so I've tried to review the HttpApi plugin based on how things have been done with other such plugins. Feel free to let me know if I've overlooked something or failed to explain something adequately.

Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py
Show resolved Hide resolved lib/ansible/module_utils/network/fortimanager/common.py
Show resolved Hide resolved lib/ansible/plugins/httpapi/fortimanager.py Outdated

@ansibot ansibot added needs_revision and removed core_review labels Jan 14, 2019

@ansibot ansibot removed the stale_ci label Jan 16, 2019

Minor doc change to kick off new shippable test. Unrelated code (not …
…our stuff) caused a failure on the last test.
@ftntcorecse

This comment has been minimized.

Copy link
Contributor

ftntcorecse commented Jan 19, 2019

@Qalthos We’ve updated the code to address your comments. Please provide feedback at your earliest convienence so we can finish this month long PR. It is holding up the rest of our module submissions. We’d like to resolve this as soon as possible. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment