Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufw: add integration tests #50374

Merged
merged 2 commits into from Dec 29, 2018
Merged

ufw: add integration tests #50374

merged 2 commits into from Dec 29, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Adds some first integration tests for the ufw module.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

ufw

@ansibot
Copy link
Contributor

ansibot commented Dec 28, 2018

cc @ahtik @ovcharenko @pyykkis
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 28, 2018
@felixfontein felixfontein force-pushed the ufw-integration-tests branch 3 times, most recently from 64a32a5 to 07aca97 Compare December 28, 2018 17:46
@felixfontein
Copy link
Contributor Author

Ok, this will do for the beginning. I don't know how to install ufw under RHEL8, and it doesn't seem to work in docker containers on shippable (ERROR: problem running ufw-init iptables xxx: can't initialize iptables table filter': Permission denied (you must be root)-- that's why I addedneeds/privileged`).

@gundalow gundalow merged commit a707f1a into ansible:devel Dec 29, 2018
@gundalow
Copy link
Contributor

@felixfontein Thanks for adding these. Once people are back we can discuss the RHEL8 issue.

@felixfontein felixfontein deleted the ufw-integration-tests branch December 29, 2018 17:32
@felixfontein
Copy link
Contributor Author

@gundalow thanks for reviewing and merging!

@felixfontein felixfontein mentioned this pull request Dec 29, 2018
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 4, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@felixfontein @kbreit
ufw: add integration tests (ansible#50374)
619accf 
* Add basic integration tests for ufw.

* Being more honest.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @gundalow @sivel