Add auth_timeout parameter when supported by paramiko #50448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgito
changed the title
ansibot
added
affects_2.8
Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors.
orgito
force-pushed
the
paramiko_add_auth_timeout
branch
from
620e5fb
to
e7f21dd
Compare
ansibot
added
core_review
sivel
reviewed
Jan 4, 2019
Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version.
|
I am wondering whether there would ever be a need to set a different auth_timeout in paramiko ? |
|
The advantage of using the same value is that it retains current expected behavior when using a version of paramiko older than 2.2. So I don't think it is necessary to handle an extra parameter here. |
samdoran
removed
the
needs_triage
|
Please create a changelog fragment. See this fragment as an example. |
ansibot
added
the
support:community
This comment has been minimized.
This comment has been minimized.
ansibot
added
ci_verified
orgito
force-pushed
the
paramiko_add_auth_timeout
branch
from
9fe5863
to
7679a92
Compare
ansibot
added
core_review
Thank you. It is done |
|
rebuild_merge |
ansibot
added
shipit
orgito
added a commit
to orgito/ansible
that referenced
this pull request
Jan 9, 2019
Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. (cherry picked from commit e7f21dd) Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. (cherry picked from commit 6c41e97) Add changelog fragment (cherry picked from commit 7679a92)
abadger
pushed a commit
that referenced
this pull request
Jan 9, 2019
Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. (cherry picked from commit e7f21dd) Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. (cherry picked from commit 6c41e97) Add changelog fragment (cherry picked from commit 7679a92)
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. * Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. * Add changelog fragment
knumskull
pushed a commit
to knumskull/ansible
that referenced
this pull request
Jan 21, 2019
* Add auth_timeout parameter when supported Paramiko 2.2 introduces the auth_timeout parameter. This will set the parameter to the same value of the timeout parameter to prevent "Authentication timeout" errors. * Conditionally add auth_timeout to ssh.connect Renamed sock_kwarg to ssh_connect_kwargs and conditionally added the auth_timeout parameter based on the installed paramiko version. * Add changelog fragment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paramiko 2.2 introduces the auth_timeout parameter. This will set the
parameter to the same value of the timeout parameter to prevent
"Authentication timeout" errors.
SUMMARY
If the paramiko version installed is at least 2.2 include the auth_timeout parameter to the connect method with the same value used for the timeout method. This will prevent "Authentication timeout" errors when a slow authentication step (>30s) happens with a host. This is common with some network devices.
Fixes #42596
ISSUE TYPE
COMPONENT NAME
paramiko_ssh connection plugin
ADDITIONAL INFORMATION
I noticed that problem when using the network_cli connection plugin, which in turn uses the paramiko_ssh connection plugin.