Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnf - fix conf_file loading #50515

Merged
merged 1 commit into from Jan 3, 2019
Merged

dnf - fix conf_file loading #50515

merged 1 commit into from Jan 3, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Fix issue where the dnf module would ignore any [main] configs inside a conf_file. This is because conf.config_file_path needs to be set before conf.read() is called. Also updated a test to test out this issue instead of modifying the global /etc/dnf/dnf.conf file.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot
Copy link
Contributor

ansibot commented Jan 3, 2019

cc @DJMuggs @berenddeschouwer @ignatenkobrain
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 3, 2019
@ansibot ansibot merged commit 63e454a into ansible:devel Jan 3, 2019
@jborean93 jborean93 deleted the dnf-conf-file branch January 3, 2019 20:28
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 3, 2019
@jborean93
dnf - fix conf_file loading (ansible#50515)
4a14229 
(cherry picked from commit 63e454a)
@jborean93 jborean93 mentioned this pull request Jan 3, 2019
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.7 #50516. Looks like stable-2.6 is unaffected by this issue as conf.read() is run after the conf file is set.

abadger pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @abadger
dnf - fix conf_file loading (#50515)
6a76fe3 
(cherry picked from commit 63e454a)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
dnf - fix conf_file loading (ansible#50515)
f174a27
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @maxamillion @ansibot