Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashi_vault lookup: add env variable VAULT_AUTH_METHOD #50572

Merged
merged 1 commit into from Jan 7, 2019
Merged

hashi_vault lookup: add env variable VAULT_AUTH_METHOD #50572

merged 1 commit into from Jan 7, 2019

Conversation

devjatkin
Copy link
Contributor

SUMMARY

I would like to introduce environment variable VAULT_AUTH_METHOD for hashi_vault lookup to manipulate authentication method.

With feature will be possible to switch between "AppRole" and "Token" methods using only environment variables.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/lookup/hashi_vault.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jan 5, 2019
resmo
resmo approved these changes Jan 6, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@resmo resmo merged commit 618caf2 into ansible:devel Jan 7, 2019
@resmo
Copy link
Contributor

resmo commented Jan 7, 2019

Thanks

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 7, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@devjatkin @kbreit
add env variable VAULT_AUTH_METHOD (ansible#50572)
c1940b2
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devjatkin @resmo @sivel @ansibot