Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve style and fix typos in the Zabbix module titles and descriptions #50575

Merged
merged 9 commits into from Jan 6, 2019
Merged

Improve style and fix typos in the Zabbix module titles and descriptions #50575

merged 9 commits into from Jan 6, 2019
+28 −28

Conversation

richlv
Copy link
Contributor

@richlv richlv commented Jan 5, 2019

SUMMARY

Improve style and fix typos in the Zabbix module titles and descriptions.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

zabbix_template
zabbix_screen
zabbix_proxy
zabbix_map
zabbix_hostmacro
zabbix_host_facts
zabbix_host
zabbix_group

@richlv
Update zabbix_group.py
c44d7ca 
Improve Zabbix module title style.

+label: docsite_pr
@richlv
Update zabbix_host.py
5096ada 
Improve style in the Zabbix module titles
@richlv
Update zabbix_host_facts.py
29b4e9a 
Improve style in the Zabbix module titles and descriptions
@richlv
Update zabbix_hostmacro.py
55a55ca 
Improve style in the Zabbix module titles and descriptions
@richlv
Update zabbix_map.py
d16d2f5 
Improve style in the Zabbix module titles and descriptions
@richlv
Update zabbix_proxy.py
0d8d2b7 
Improve style in the Zabbix module titles and descriptions
@richlv
Update zabbix_screen.py
87927a1 
Improve style in the Zabbix module titles and descriptions
@richlv
Update zabbix_template.py
89fd70b 
Improve style in the Zabbix module titles and descriptions
@ansibot
Copy link
Contributor

ansibot commented Jan 5, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/monitoring/zabbix/zabbix_template.py:0:0: E305 DOCUMENTATION.options.state.description.0: expected str @ data['options']['state']['description'][0]. Got {'State': 'present - create/update template; absent - delete template'}

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 5, 2019

cc @Akint @D3DeFi @akomic @cove @dj-wasabi @eikef @harrisongu @logan2211 @RedWhiteMiko @sookido
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 5, 2019
@richlv
Update zabbix_template.py
6cd759f 
Attempt to fix a failing test
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 5, 2019
@dj-wasabi
Copy link
Contributor

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 5, 2019
@resmo
Copy link
Contributor

resmo commented Jan 6, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 6, 2019
@resmo resmo merged commit 9093ca1 into ansible:devel Jan 6, 2019
@richlv richlv deleted the patch-9 branch January 8, 2019 16:05
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@richlv @kbreit
Improve style and fix typos in the Zabbix module titles and descripti…
87e787f 
…ons (ansible#50575)
@dagwieers dagwieers added the zabbix Zabbix community label Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richlv @ansibot @dj-wasabi @resmo @dagwieers