fix eos_l2_interface invalid command #50644
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ansibot
added
affects_2.8
tetsuyasodo
reviewed
Jan 9, 2019
| @@ -176,9 +176,9 @@ def map_obj_to_commands(updates, module): | |||
| commands.append('switchport trunk allowed vlan {0}'.format(trunk_allowed_vlans)) | |||
| else: | |||
| if obj_in_have['native_vlan']: | |||
| commands.append('not switchport trunk native vlan {0}'.format(obj_in_have['native_vlan'])) | |||
| commands.append('no switchport trunk native vlan {0}'.format(obj_in_have['native_vlan'])) | |||
There was a problem hiding this comment.
For EOS, following line is also required after this line:
commands.append( 'no switchport mode trunk')
tetsuyasodo
reviewed
Jan 9, 2019
| if obj_in_have['trunk_allowed_vlans']: | ||
| commands.append('not switchport trunk allowed vlan {0}'.format(obj_in_have['trunk_allowed_vlans'])) | ||
| commands.append('no switchport trunk allowed vlan {0}'.format(obj_in_have['trunk_allowed_vlans'])) |
There was a problem hiding this comment.
For EOS, following line is also required after this line:
commands.append( 'no switchport mode trunk')
|
Line172 should be modified as follows: |
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
Apr 1, 2019
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 1400d16)
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 1400d16)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
fixes #50639
ISSUE TYPE
COMPONENT NAME
modules/network/eos/eos_l2_interface.py