Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup - required: false #50648

Merged
merged 1 commit into from Jan 10, 2019
Merged

cleanup - required: false #50648

merged 1 commit into from Jan 10, 2019

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Jan 8, 2019

SUMMARY

Specifying required as False is not required.
Cleaned it up in all remaining modules.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_containerregistry
azure_rm_managed_disk_facts
azure_rm_networkinterface
azure_rm_resource
azure_rm_resource_facts
azure_rm_sqlserver
azure_rm_virtualmachine_extension

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 8, 2019

cc @brusMX @haroldwongms @julienstroheker @nitzmahone @sozercan @trstringer @xscript @yaweiw @yuwzho
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 8, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Jan 9, 2019
Closed
@Fred-sun
Copy link
Contributor

Fred-sun commented Jan 9, 2019

@yuwzho @yungezz

@zikalino zikalino requested a review from yungezz January 9, 2019 14:10
@yungezz
Copy link
Contributor

yungezz commented Jan 10, 2019

shipit

@yungezz yungezz merged commit 3739dc9 into ansible:devel Jan 10, 2019
@yungezz yungezz deleted the cleanup-required-false branch January 10, 2019 01:26
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 10, 2019
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@kbreit
cleanup - required: false (ansible#50648)
8c48e1e
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@knumskull
cleanup - required: false (ansible#50648)
9954e62
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zikalino @ansibot @Fred-sun @yungezz @sivel