Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_psexec: added the pid return value to the docs #50664

Merged
merged 1 commit into from Jan 9, 2019
Merged

win_psexec: added the pid return value to the docs #50664

merged 1 commit into from Jan 9, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Adds the pid return value to the docs which is used when wait: False. This value is the process ID of the async process spawned by PsExec.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

win_psexec

@ansibot
Copy link
Contributor

ansibot commented Jan 8, 2019

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Jan 8, 2019
dagwieers
dagwieers approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dagwieers dagwieers merged commit 13a2a8b into ansible:devel Jan 9, 2019
@dagwieers
Copy link
Contributor

If we would want to backport this to v2.7 we may want to add a changelog.

@jborean93 jborean93 deleted the win_psexec-docs branch January 9, 2019 00:50
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 9, 2019
@jborean93
win_psexec: added the pid return value to the docs (ansible#50664)
729b13e 
(cherry picked from commit 13a2a8b)
jborean93 added a commit to jborean93/ansible that referenced this pull request Jan 9, 2019
@jborean93
win_psexec: added the pid return value to the docs (ansible#50664)
4ce2de2 
(cherry picked from commit 13a2a8b)
This was referenced Jan 9, 2019
Merged
Merged
@jborean93
Copy link
Contributor Author

thanks @dagwieers, if the RM's want me to create a changelog fragment I will but we usually don't do it for doc changes.

Backport PRs
stable-2.6 #50690
stable-2.7 #50691

@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2019
@dagwieers
Copy link
Contributor

Even better :-)

abadger pushed a commit that referenced this pull request Jan 9, 2019
@jborean93 @abadger
win_psexec: added the pid return value to the docs (#50664)
3ff477d 
(cherry picked from commit 13a2a8b)
mattclay pushed a commit that referenced this pull request Jan 9, 2019
@jborean93 @mattclay
win_psexec: added the pid return value to the docs (#50664)
fb5cd98 
(cherry picked from commit 13a2a8b)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
win_psexec: added the pid return value to the docs (ansible#50664)
e6d2603
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@jborean93 @knumskull
win_psexec: added the pid return value to the docs (ansible#50664)
4073ec6
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @dagwieers