Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] make callback invocation async #50718

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 9, 2019

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

callbacks/core

@ansibot ansibot added WIP affects_2.8 feature needs_triage support:core labels Jan 9, 2019
@bcoca bcoca removed the needs_triage label Jan 15, 2019
@@ -348,7 +349,7 @@ def send_callback(self, method_name, *args, **kwargs):

for method in methods:
try:
method(*new_args, **kwargs)
self._callback_pool.apply_async(method, new_args, kwargs)
Copy link
Member Author

@bcoca bcoca Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check serialization of args before using async

@ansible ansible deleted a comment from ansibot Jan 19, 2019
@ansibot ansibot added the stale_ci label Jan 29, 2019
@ansibot ansibot added the needs_rebase label Apr 3, 2019
@ansibot ansibot removed the needs_rebase label Aug 7, 2020
@ansibot ansibot added the needs_rebase label Aug 23, 2020
@ansibot ansibot added pre_azp and removed stale_ci labels Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.8 feature needs_rebase pre_azp support:core WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants