Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added missing docs for option in acl module (#50775) #50806

Merged
merged 2 commits into from Jan 16, 2019
Merged

added missing docs for option in acl module (#50775) #50806

merged 2 commits into from Jan 16, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 11, 2019

  • added missing docs for option in acl module
  • remove acl from ignore

(cherry picked from commit 91d8383)

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

files/acl

@bcoca
added missing docs for option in acl module (ansible#50775)
dbe0377 
* added missing docs for option in acl module
* remove acl from ignore

(cherry picked from commit 91d8383)
@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 11, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 11, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2019
mattclay
mattclay requested changes Jan 15, 2019
View reviewed changes
lib/ansible/modules/files/acl.py Outdated Show resolved Hide resolved
@ansibot
Copy link
Contributor

ansibot commented Jan 16, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/files/acl.py:0:0: E309 version_added for new option (use_nfsv4_acls) should be 2.6. Currently 2.2

click here for bot help

@mattclay mattclay merged commit 421a378 into ansible:stable-2.6 Jan 16, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @ansibot @mattclay