Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: provide alternatives to ansible_facts results #51192

Merged
merged 2 commits into from Feb 18, 2019
Merged

docker: provide alternatives to ansible_facts results #51192

merged 2 commits into from Feb 18, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Some of the docker_* modules use ansible_facts to return facts. This is not a good idea, facts should only be returned by _facts modules. (The docker_*_facts modules don't, but that's another story.)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_container
docker_network
docker_service
docker_volume

@ansibot
Copy link
Contributor

ansibot commented Jan 22, 2019

cc @DBendit @agronholm @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @keitwb @olsaki @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 22, 2019
@felixfontein
Copy link
Contributor Author

Rebased to adjust to docker_service → docker_compose rename.

@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 24, 2019
@felixfontein felixfontein reopened this Jan 27, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 27, 2019
@felixfontein felixfontein mentioned this pull request Jan 29, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 4, 2019

cc @WojciechowskiPiotr
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 4, 2019
gundalow
gundalow approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 13, 2019
@felixfontein
Copy link
Contributor Author

@gundalow what do you think about removing the ansible_facts return values eventually? I guess it should be announced in time (probably mentioned in at least four porting guides in a row, or so), especially since there is no way to flag uses of these.

@felixfontein
Copy link
Contributor Author

shipit

@gundalow gundalow merged commit 37b0f5c into ansible:devel Feb 18, 2019
@felixfontein felixfontein deleted the docker-ansible_facts branch February 18, 2019 14:36
@felixfontein felixfontein mentioned this pull request Feb 18, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibot @gundalow