Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pacman package state detection #51311

Merged
merged 7 commits into from Aug 8, 2019
Merged

fix pacman package state detection #51311

merged 7 commits into from Aug 8, 2019

Conversation

greyltc
Copy link
Contributor

@greyltc greyltc commented Jan 25, 2019

SUMMARY

Fixes #51265

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pacman

ADDITIONAL INFORMATION

This is a fix to correctly detect a package's installation status as being absent when it is not installed but another package provides it.

@greyltc
fix pacman package state detection
230e531 
This is a fix to correctly detect a package's installation status as being absent when it is not installed but another package provides it.
@greyltc greyltc mentioned this pull request Jan 25, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 25, 2019

cc @indrajitr @tchernomax
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 25, 2019
resmo
resmo approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, but I am not a arch user, giving it a 👍 and waiting for another reviewer

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 26, 2019
tchernomax
tchernomax suggested changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you feel about those suggestions ?
(feel free to apply them to get_version too)

lib/ansible/modules/packaging/os/pacman.py Outdated Show resolved Hide resolved
lib/ansible/modules/packaging/os/pacman.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/packaging/os/pacman.py:185:4: undefined-variable Undefined variable 'module'

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 26, 2019
tchernomax
tchernomax suggested changes Jan 26, 2019
View reviewed changes
lib/ansible/modules/packaging/os/pacman.py Outdated Show resolved Hide resolved
lib/ansible/modules/packaging/os/pacman.py Show resolved Hide resolved
lib/ansible/modules/packaging/os/pacman.py Outdated Show resolved Hide resolved
lib/ansible/modules/packaging/os/pacman.py Show resolved Hide resolved
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 3, 2019
tchernomax and others added 2 commits February 4, 2019 18:39
@tchernomax @greyltc
Update lib/ansible/modules/packaging/os/pacman.py
3dcb5a9 
Co-Authored-By: greyltc <grey@christoforo.net>
@tchernomax @greyltc
Update lib/ansible/modules/packaging/os/pacman.py
79de35f 
Co-Authored-By: greyltc <grey@christoforo.net>
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 4, 2019
@greyltc
Copy link
Contributor Author

greyltc commented Feb 7, 2019

Is there anything left that needs to be done here?

@resmo
Copy link
Contributor

resmo commented Feb 7, 2019

ready_for_review

@ansibot ansibot added the packaging Packaging category label Feb 15, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 15, 2019
tchernomax
tchernomax approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@tchernomax tchernomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 17, 2019
@indrajitr
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 10, 2019
@ansibot ansibot removed the automerge This PR was automatically merged by ansibot. label Jul 18, 2019
@ansibot ansibot added has_issue automerge This PR was automatically merged by ansibot. and removed automerge This PR was automatically merged by ansibot. labels Jul 26, 2019
@ansibot ansibot added automerge This PR was automatically merged by ansibot. and removed automerge This PR was automatically merged by ansibot. labels Aug 8, 2019
@resmo resmo merged commit 29f89b3 into ansible:devel Aug 8, 2019
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@indrajitr indrajitr indrajitr approved these changes

@tchernomax tchernomax tchernomax approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. packaging Packaging category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pacman module state: absent verification failure when package name is provided by another
5 participants
@greyltc @ansibot @resmo @indrajitr @tchernomax