Do not add state: absent when a non-existent path is returned in "path" or "dest" #51350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
tempted to say the whole 'add_path_info' should not be automatically called, leave function as it is, but force the call only from specific modules instead of all (pass add_path_info=true? to _json functions?) |
ansibot
removed
the
needs_triage
|
I had no problem doing this myself though. I only needed to know if this would be accepted. |
ansibot
added
needs_revision
nitzmahone
approved these changes
Jan 25, 2019
ansibot
added
core_review
|
@dag I can't let you have all the fun. 😉 |
ansibot
added
the
stale_ci
Leave it up to the module to return the state in the results. I went through all the modules in files/ and only found one case where the module needed to return this. No other modules return paths that do not exists. Signed-off-by: Sam Doran <sdoran@redhat.com>
samdoran
force-pushed
the
issue/35382-state-absent-path
branch
from
978a488
to
f49c3c7
Compare
ansibot
added
needs_revision
ansibot
added
the
stale_ci
|
@samdoran Is this ready to be merged ? |
ansibot
removed
core_review
ansibot
added
shipit
|
@dag Yes, it's ready to be merged. Just trying to make tests happy though the failures seem unrelated to this PR. |
ansibot
added
shipit
|
All green. Thanks again ! |
openstack-gerrit
pushed a commit
to openstack/openstack-ansible-lxc_hosts
that referenced
this pull request
May 17, 2019
Ansible 2.8 does not return a "state" attribute if the file does not exist[1], so the task is changed to use stat instead. [1] ansible/ansible#51350 Change-Id: I166186b6d8abf84317ba98af949d4ed887618912
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
May 17, 2019
* Update openstack-ansible-lxc_hosts from branch 'master'
- Use stat instead of file module for exists check
Ansible 2.8 does not return a "state" attribute if the file does not
exist[1], so the task is changed to use stat instead.
[1] ansible/ansible#51350
Change-Id: I166186b6d8abf84317ba98af949d4ed887618912
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Leave it up to the module to return the state in the results.
I went through all the modules in
lib/ansible/modules/files/and only found one case where the module needed to returnstate: absent. No other modules return paths that do not exists and will therefore get the correct file type added byAnsibleModule.add_path_info().Signed-off-by: Sam Doran sdoran@redhat.com
Fixes #35382
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/basic.pylib/ansible/modules/files/file.py