flatpak: Open subprocess in text stream mode

[subpop]

This sets the return values to be 'str' instead of byte-arrays. Fixes what appears to be a python 3 compatibility problem.

SUMMARY

This sets the return values to be 'str' instead of byte-arrays. Fixes what appears to be a python 3 compatibility problem.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

flatpak

[ansibot]

cc @JayKayy @oolongbrothers
click here for bot help

[oolongbrothers]

Thanks for your contribution, @subpop !

I was recently working on Python 3 compatibility issues and added byte-array <> string conversions in other places of the module. Right now my integration tests are running successfully in both Python 2 and 3 on Fedora 28, Ubuntu 16.04 and 18.04 on latest devel (after applying the fixes from #51482). Quite possible that my tests do not cover your issue, though.

I would like to prevent your issue from regressing in future, so I would really like to have it covered by the integration tests. Could you add a test that triggers your issue to the flatpak integration test playbook at test/integration/targets/flatpak/tasks/test.yml in your branch?

I tried to document how to run the integration tests in the header of the flatpak.py file. If you haven't done any ansible module integration testing before, you might want to check out: https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html
If you should get stuck with creating the test I would be happy to help out 🙂

[oolongbrothers]

Actually, I just tried to apply your fix and I did get errors that the text-parameter is not supported. At least on Fedora 28 with Python 3.6.
Which Python version are you on when you experience your issue? And what version of flatpak (flatpak --version) are you runnning?

[subpop]

Which Python version are you on when you experience your issue? And what version of flatpak (flatpak --version) are you runnning?

I'm running Fedora 29.

ansible 2.7.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/home/link/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.7.2 (default, Jan 16 2019, 19:49:22) [GCC 8.2.1 20181215 (Red Hat 8.2.1-6)]

Flatpak 1.0.6

I'll see if I can make a test to cover this, yea.

[oolongbrothers]

I have a Fedora 29 environment with Python 2 running now, but I'm still not able to reproduce this bug.
@subpop What tasks are you executing when you get that behaviour? Also vital: What version of ansible are you running? 2.7 or are you running from the devel branch?

[ansibot]

@subpop Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

[ansibot]

@subpop Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

[gundalow]

@subpop Hi, Are you still seeing this issue in Ansible 2.8 or 2.9?

@oolongbrothers I wonder if this should be closed?

needs_info

[gundalow]

Given I have a Fedora 29 environment with Python 2 running now, but I'm still not able to reproduce this bug. I'm going to close this.

Please open a new issue/PR if this is still an issue with Ansible 2.9 (or devel)