Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_aaa_user: Fix an issue with clear_password_history #51459

Merged
merged 1 commit into from
Jan 30, 2019
Merged

aci_aaa_user: Fix an issue with clear_password_history #51459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ansible/modules/network/aci/aci_aaa_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def main():
aaa_password_lifetime = module.params['aaa_password_lifetime']
aaa_password_update_required = aci.boolean(module.params['aaa_password_update_required'])
aaa_user = module.params['aaa_user']
clear_password_history = module.params['clear_password_history']
clear_password_history = aci.boolean(module.params['clear_password_history'], 'yes', 'no')
description = module.params['description']
email = module.params['email']
enabled = aci.boolean(module.params['enabled'], 'active', 'inactive')
Expand Down
38 changes: 38 additions & 0 deletions test/integration/targets/aci_aaa_user/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,44 @@
- nm_modify_user_again.current.0.aaaUser.attributes.descr == 'Ansible test user for integration tests'


# CLEAR PASSWORD HISTORY
- name: Clear password history (check_mode)
aci_aaa_user: &clear_password_history
host: '{{ aci_hostname }}'
username: '{{ aci_username }}'
password: '{{ aci_password }}'
validate_certs: '{{ aci_validate_certs | default(false) }}'
use_ssl: '{{ aci_use_ssl | default(true) }}'
use_proxy: '{{ aci_use_proxy | default(true) }}'
output_level: '{{ aci_output_level | default("info") }}'
aaa_user: ansible
clear_password_history: yes
check_mode: yes
register: cm_clear_password_history

- name: Clear password history (normal mode)
aci_aaa_user: *clear_password_history
register: nm_clear_password_history

- name: Clear password history (check mode)
aci_aaa_user: *clear_password_history
check_mode: yes
register: cm_clear_password_history_again

- name: Clear password history (normal mode)
aci_aaa_user: *clear_password_history
register: nm_clear_password_history_again

- name: Verify clear password history
assert:
that:
# NOTE: Clearing password history is a changing action, everytime
- cm_clear_password_history is changed
- nm_clear_password_history is changed
- cm_clear_password_history_again is changed
- nm_clear_password_history_again is changed


# QUERY ALL USERS
- name: Query all users (check_mode)
aci_aaa_user: &user_query
Expand Down